From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Glenn Morris <rgm@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [Emacs-diffs] trunk r114239: * vc/vc-svn.el
	(vc-svn-retrieve-tag): Mark unused argument.
Date: Thu, 12 Sep 2013 11:54:11 -0400
Message-ID: <5kioy69gt8.fsf@fencepost.gnu.org>
References: <E1VK0oK-00066t-Hr@vcs.savannah.gnu.org>
	<jwvppse1b2q.fsf-monnier+emacs@gnu.org>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: ger.gmane.org 1379001301 23529 80.91.229.3 (12 Sep 2013 15:55:01 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Thu, 12 Sep 2013 15:55:01 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 12 17:55:04 2013
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1VK9Dk-0002Gh-Bk
	for ged-emacs-devel@m.gmane.org; Thu, 12 Sep 2013 17:54:16 +0200
Original-Received: from localhost ([::1]:42553 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1VK9Dk-0001Nz-1B
	for ged-emacs-devel@m.gmane.org; Thu, 12 Sep 2013 11:54:16 -0400
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50998)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <rgm@gnu.org>)
	id 1VK9Dh-0001Nt-3e
	for emacs-devel@gnu.org; Thu, 12 Sep 2013 11:54:14 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rgm@gnu.org>) id 1VK9Dg-0004Ys-62
	for emacs-devel@gnu.org; Thu, 12 Sep 2013 11:54:13 -0400
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51041)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <rgm@gnu.org>)
	id 1VK9Dg-0004Ym-2W
	for emacs-devel@gnu.org; Thu, 12 Sep 2013 11:54:12 -0400
Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71)
	(envelope-from <rgm@gnu.org>)
	id 1VK9Df-0000Bo-8M; Thu, 12 Sep 2013 11:54:11 -0400
X-Spook: Rand Corporation Kh-11 CipherTAC-2000 Peking Glock
X-Ran: $C)3#rSPDx0HDc^Bj#%aH/c]'VQmzD'<LdSXyxFe-c;T%o^zKZ&{y_Kla7#3c2/LlY:sJT
X-Hue: cyan
X-Attribution: GM
In-Reply-To: <jwvppse1b2q.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message
	of "Thu, 12 Sep 2013 08:26:14 -0400")
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
	(bad octet value).
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:163312
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/163312>

Stefan Monnier wrote:

>> -(defun vc-svn-retrieve-tag (dir name update)
>> +(defun vc-svn-retrieve-tag (dir name _update)
[...[
> I'm not sure this is a good idea.  Is there a good reason why `update'
> is ignored?  If not, then the fact that `update' is ignored is a bug,
> and we shouldn't silence it.

It's got a fixme comment, everyone pays attention to those, right?