From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Use vtable for eww-bookmarks Date: Thu, 28 Nov 2024 11:49:02 -0800 Message-ID: <5f52e217-6eb9-968b-300c-faaf5b18e84e@gmail.com> References: <9c2c262e-320d-139b-cf6a-5b93cd98eb8b@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36698"; mail-complaints-to="usenet@ciao.gmane.io" To: =?UTF-8?B?U2ViYXN0acOhbiBNb27DrWE=?= , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 28 20:49:57 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tGkWS-0009RG-H6 for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Nov 2024 20:49:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tGkVk-0004eC-7l; Thu, 28 Nov 2024 14:49:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGkVf-0004ds-E8 for emacs-devel@gnu.org; Thu, 28 Nov 2024 14:49:07 -0500 Original-Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tGkVd-0006RG-Ot for emacs-devel@gnu.org; Thu, 28 Nov 2024 14:49:07 -0500 Original-Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-7250906bc63so838883b3a.1 for ; Thu, 28 Nov 2024 11:49:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732823344; x=1733428144; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=MluWcTuh8cmx1DwH6ubW8n+VFTRF2B8dDvXwHise+aY=; b=kLfM2hQs+W7uXX6yMZcIF7BEotGXdtHN//0pYH4uAGnCEQOSHPFa725BS+Euh9Zjby wlmeEuSQTP9uGBrSdICiRnFDp4+nhUm7SKRwGoUBOUBc2cUHp8vS5O4ypV+IkroyzBJk hjs21DhzjDeOQmnoUjK8ajAXHv3DUzgdXa/UqmqyD80lfeFGI+kyNXslghgU5byihIS0 jInaV/Mur+dbvNgkHh0hpRxAu615bqHEjvLniX4fr4qziP6rlkwHUvIowflxmcP3eZ45 IU+byHCG9wLhQtLf87Z3/UQWecJoMFvRBxIkAj4/UU9IpcnE/BAw5XgZEmNWECMY3HfG hSMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732823344; x=1733428144; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MluWcTuh8cmx1DwH6ubW8n+VFTRF2B8dDvXwHise+aY=; b=jRHCeOlpubYSKfd+QhVRs1Fs9F44A6Ef0WZL7ebAGXUiv5+GVOqxFJlP+XWylkfJz8 3M8QUwEw85omoKuVwzsmgqVBehd+JAXeZdZaXZzfyktCU68cI25+KSdazeC41gFhEeAE /dh7mYxT90zbY/q7DqZ8BIs7KXDO2MuX+WfZe+hxAUAFYkjqzwXTCjiMwkBwMGLMnT04 6qfxfE5nEsoBuNj8H1i1Nle+ZQx34BD51XeehM/xWQLGkN1F9+SOINZMeyMnmo0ACkR1 89YhHVrB1yCjpFGYr27ddhMaeXQy6/0Gq/xWvM3C6Ljjv0ywV5B4Xk8/Nm/RLM4Sm56U AlJQ== X-Forwarded-Encrypted: i=1; AJvYcCWdlcx03g9Pvlk6/Jfi+G7HmhxxUK2YCwWjmsahPdxsNsy7YnZ1flxIS9wTb5RgJbZu7ytm01w66lSGEA==@gnu.org X-Gm-Message-State: AOJu0YzblKdQbnYdWykuB9TZTCW2AOu4dMuSHJ2CbhJ+BEE1IUT0UQTs g1eLdzo2lMwWCZzs2tGdDrFb2r3vkpoUOOod/zDa5u6EP7JQIFo6eLkPqw== X-Gm-Gg: ASbGncswE5y76FfjmD3necMS+Ee0A2037JIT53wyNv7eKxHb1piIM2UjpfxNF4+/YPl WDYCHr1uFLD6F4J4ibVoBItvGItHhk+1u9wFl4FMTbzuVqWCIyfUjLQ80ZatffixGMmNMbi28sk hCGJgBdOAe5ftUb0M0t8pFmxFTxbKpD0HdCEzF13iqaCOnFjjz9sXtdB1ne/dj0rvPYNs6nseub RDLIsRetcPmHcZ32d/baIEBG4kxgOYEJITYHZeOPIMcUVYBFVWA9cHEyJwYKf4lxSBeEvCmu0xw bauW8l2jRr/O2kf5yD/T794HV6o= X-Google-Smtp-Source: AGHT+IEeOoMn7qHbYezwZQ3uF2zAOsR0AEbVTK22jkgoSMQ1AWYl6J2EiTsxUsli2oTe/k/d3bjWow== X-Received: by 2002:aa7:93b5:0:b0:725:3fb5:5151 with SMTP id d2e1a72fcca58-7253fb5528amr5564130b3a.12.1732823343770; Thu, 28 Nov 2024 11:49:03 -0800 (PST) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-725417fba22sm1945127b3a.113.2024.11.28.11.49.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Nov 2024 11:49:03 -0800 (PST) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::433; envelope-from=jporterbugs@gmail.com; helo=mail-pf1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325832 Archived-At: On 11/27/2024 12:02 PM, Sebastián Monía wrote: > On Sat, Nov 23, 2024, at 2:12 PM, Jim Porter wrote: >> I think this looks good overall. Just one thought: instead of requiring >> users to manually undo sorting when killing/yanking, what if we had >> 'eww-bookmark-kill' and 'eww-yank-bookmark' prompt the user to ask if >> they want to undo the sorting first? > > The problem is, when yanking, do you yank the bookmark to the > current position on the table? or the one where you will end up after > undoing the sort? Good point. For what it's worth, I tried reordering bookmarks in the "Library" window in Firefox, and it works as in your patch: when sorting is active, you can't reorder the bookmarks. Firefox just shows a "No" icon and doesn't let you drag-and-drop. Given that, let's go with your implementation, though I do have one last concern with the "undo sort": the keybinding ("u") is the same as what other table-like modes (e.g. dired, list-packages) use for "unmark". Currently we don't support marking/unmarking in the bookmarks menu, but that seems like a useful thing we might add one day: you could mark several bookmarks in order to open them all, delete them all, add some kind of tag to them, etc. I'm not sure what a better key would be though. Maybe "C" for "clear sort"?