From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jason Kim Newsgroups: gmane.emacs.devel Subject: Re: Small shell-mode patch to handle auto-cd (e.g. shells like zsh) Date: Sat, 8 May 2021 10:58:39 -0700 Message-ID: <5f1f7466-c038-d7f6-1743-ca998d2b52e1@revtera.com> References: <83v97we0ey.fsf@gnu.org> <83v97tag0r.fsf@gnu.org> <831rah9no1.fsf@gnu.org> <2a15023f-94b3-4726-6cc8-d7a8dd8e5aaa@icloud.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12534"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Cc: michael.albinus@gmx.de, shivers@cs.cmu.edu, emacs-devel@gnu.org To: Jason Kim , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 08 22:33:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfTdP-0003Ap-PB for ged-emacs-devel@m.gmane-mx.org; Sat, 08 May 2021 22:33:11 +0200 Original-Received: from localhost ([::1]:37254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfTdO-0007Q4-SO for ged-emacs-devel@m.gmane-mx.org; Sat, 08 May 2021 16:33:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfRE3-0003sC-Lz for emacs-devel@gnu.org; Sat, 08 May 2021 13:58:51 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:41159) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfRE1-0003I2-EL; Sat, 08 May 2021 13:58:51 -0400 Original-Received: from [10.26.18.5] (unknown [143.244.48.87]) (Authenticated sender: jason.kim@revtera.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 4FCB6240009; Sat, 8 May 2021 17:58:41 +0000 (UTC) In-Reply-To: <2a15023f-94b3-4726-6cc8-d7a8dd8e5aaa@icloud.com> Content-Language: en-US Received-SPF: pass client-ip=217.70.178.230; envelope-from=jason.kim@revtera.com; helo=relay10.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 08 May 2021 16:32:39 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269065 Archived-At: On 5/8/21 10:19 AM, Jason Kim wrote: Eli, Hi, I'd like to walk back anything that may seem like a criticism. I did not mean to imply any such, and apologies if you were taken aback. The main point here simply is that AFAIK, the switch is the simplest, least intrusive way to get this very small support capability in to shell mode, and that additional upgrades are perfectly possible, but IMHO not apropos at the moment. Thanks again, and hopefully you guys are ok with it. -Jason > Sure, I suppose, but why do it? I'm a zsh user and I'm perfectly fine > with it as a switch that I can put in my .emacs :-) > > and hijacking comint like that can add glitches, and introduce > irreproducibility (I automate creation of shells, pasting commands to > comint etc..). > > Auto injecting commands to what should be a user-input space seems a bit > wierd just to support this feature, and may not be optimal, because it > is unexpected > > I'd be happy to help with this improvement, if that's REALLY what you > want but it can add glitches to user's automation of shells, but I don't > think its necessary (for now), and I humbly request we punt on it. > > Thanks! > -Jason >