From: Drew Adams <drew.adams@oracle.com>
To: Juri Linkov <juri@linkov.net>, Paul Eggert <eggert@cs.ucla.edu>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: RE: master 71783e9: Add the string-numeric-lessp function
Date: Sun, 6 Mar 2016 18:27:50 -0800 (PST) [thread overview]
Message-ID: <5ea313cd-bc7f-4c18-abe3-69bcc4838cbf@default> (raw)
In-Reply-To: <8737s3jfrr.fsf@mail.linkov.net>
`string-numeric-lessp' really should follow the Emacs
convention and be called `string-numeric-less-p'.
It's not because `string-less-p' is misnamed that we
should add to this mistake. `time-less-p' is correctly
named, for example.
Or else the rule should be clarified to incorporate
`-lessp' exceptions, so they are within, and not outside,
the rule.
The following 25 are the only such misnamed predicates
I see (in a pretty minimal setup - there may be some
more in Gnus, Org, etc.). 6 of them end in `-lessp'.
auth-source-specmatchp
bool-vector-subsetp
byte-compile-nilconstp
byte-compile-trueconstp
byte-optimize-all-constp
byte-optimize-zerop
cl--compiler-macro-typep
cl--macroexp-fboundp
coding-system-lessp
custom-facep
customize-version-lessp
default-boundp
dired-tree-lessp
eieio--typep
file-attributes-lessp
gnus-boundp
gnutls-error-fatalp
gnutls-errorp
hack-one-local-variable-constantp
hack-one-local-variable-eval-safep
hack-one-local-variable-quotep
ls-lisp-string-lessp
slot-boundp
string-lessp
uniquify-item-greaterp
That's 25 out of 438 predicates total whose names end in
`p', which I count at the outset in a pretty minimal setup.
So less than 6% of predicate names that end in `p' do not
follow the rule. 94% follow it correctly.
The following predicates are also wrongly named, but they
should not have prefix `cl-' anyway. Remove the misguided
prefix and these names will all follow the rule.
cl-endp
cl-equalp
cl-evenp
cl-minusp
cl-oddp
cl-plusp
cl-subsetp
cl-tailp
cl-typep
next prev parent reply other threads:[~2016-03-07 2:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160221043348.25201.81719@vcs.savannah.gnu.org>
[not found] ` <E1aXLiO-0006ZB-4R@vcs.savannah.gnu.org>
2016-02-21 4:43 ` master 71783e9: Add the string-numeric-lessp function Lars Ingebrigtsen
2016-02-21 5:36 ` Lars Ingebrigtsen
2016-02-21 6:15 ` Stephan Mueller
2016-02-21 10:02 ` Lars Ingebrigtsen
2016-02-21 19:35 ` Yuri Khan
2016-02-22 2:51 ` Lars Ingebrigtsen
2016-02-22 17:59 ` Richard Stallman
2016-02-21 21:30 ` Paul Eggert
2016-02-22 1:32 ` Andy Moreton
2016-02-22 4:01 ` Paul Eggert
2016-02-22 16:11 ` Eli Zaretskii
2016-02-22 2:53 ` Lars Ingebrigtsen
2016-02-22 3:50 ` Paul Eggert
2016-02-22 4:00 ` Lars Ingebrigtsen
2016-02-22 4:16 ` Paul Eggert
2016-02-22 4:22 ` Lars Ingebrigtsen
2016-02-22 5:56 ` Paul Eggert
2016-03-07 0:16 ` Juri Linkov
2016-03-07 0:53 ` Paul Eggert
2016-03-07 17:45 ` Richard Stallman
2016-03-07 17:49 ` Lars Magne Ingebrigtsen
2016-03-07 23:55 ` Juri Linkov
2016-03-07 23:52 ` Juri Linkov
2016-03-08 2:06 ` Paul Eggert
2016-03-08 9:26 ` Andreas Schwab
2016-03-09 9:26 ` Paul Eggert
2016-03-07 2:27 ` Drew Adams [this message]
2016-03-07 21:14 ` Johan Bockgård
2016-03-07 22:03 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ea313cd-bc7f-4c18-abe3-69bcc4838cbf@default \
--to=drew.adams@oracle.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).