From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nathaniel Flath Newsgroups: gmane.emacs.devel Subject: Minor bug in cc-menus.el: cc-imenu-java-generic-expression does not match all Java 1.5+ function definitions. Date: Sat, 18 Jul 2009 08:27:10 -0700 Message-ID: <5e3a506e0907180827k148fe0d1x34b89f1fedf6c79d@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=000e0cd172e6d6db4a046efc890e X-Trace: ger.gmane.org 1247930906 4559 80.91.229.12 (18 Jul 2009 15:28:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 18 Jul 2009 15:28:26 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 18 17:28:19 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MSBph-0000x6-Gg for ged-emacs-devel@m.gmane.org; Sat, 18 Jul 2009 17:28:17 +0200 Original-Received: from localhost ([127.0.0.1]:47832 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MSBpg-0003qi-MR for ged-emacs-devel@m.gmane.org; Sat, 18 Jul 2009 11:28:16 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MSBok-0003hF-9n for emacs-devel@gnu.org; Sat, 18 Jul 2009 11:27:18 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MSBof-0003eJ-An for emacs-devel@gnu.org; Sat, 18 Jul 2009 11:27:17 -0400 Original-Received: from [199.232.76.173] (port=53446 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MSBoe-0003e9-PH for emacs-devel@gnu.org; Sat, 18 Jul 2009 11:27:12 -0400 Original-Received: from mail-pz0-f202.google.com ([209.85.222.202]:58480) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MSBoe-0006Ed-3Z for emacs-devel@gnu.org; Sat, 18 Jul 2009 11:27:12 -0400 Original-Received: by pzk40 with SMTP id 40so1018444pzk.14 for ; Sat, 18 Jul 2009 08:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type; bh=AyE05Qr/SWzciB5X4kPDWTwvj5NSkwlBk098OpwVKzY=; b=i9E2oUchkCujkr5bNKmmhmVaXFMsk+mn3IEqcsaVH4i4lgspu/EGrD5VU1VQfQnOKF w590DqBEdzHknFppJpsHWeok2rhPE4O/CuhS1bwNMPfBu//WTTru4E88M7GrYNcDuNiU 1nv0P9xUkMiQRcGwWMDrqN62BxtkSEWZ2/nT4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=FYVJx7zVc5gIL9S7xScPd0uYP6uZ7oQ722plsJPNWEHe2H539s3khgRc4XQleInVZi ZLTfU0fprhIbUIqSva3RKejfsdDDGYB0u+rJ05eET15Jl57QkvcolKb/Dvt6zZ6sdxd0 2svmI6Wv5SbkB8oGEVqlJtYT3Pa1vEQUZC7Cc= Original-Received: by 10.141.49.20 with SMTP id b20mr1155647rvk.1.1247930830215; Sat, 18 Jul 2009 08:27:10 -0700 (PDT) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:112685 Archived-At: --000e0cd172e6d6db4a046efc890e Content-Type: multipart/alternative; boundary=000e0cd172e6d6db40046efc890c --000e0cd172e6d6db40046efc890c Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit I was using Imenu, and noticed that it currently doesn't recognize Java functions with either: Generics e.g : public List foo() { ... or annotated arguments, e.g : public void foo( @NonNull bar ) { The issue was the variable cc-imenu-java-generic-expression. Attached is my patch which modifies this variables to accept all function definitions and should fix this issue. Thanks! Nathaniel Flath --000e0cd172e6d6db40046efc890c Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit I was using Imenu, and noticed that it currently doesn't recognize Java functions with either:
Generics e.g : public List<String> foo() { ...
or annotated arguments, e.g : public void foo( @NonNull bar ) {


The issue was the variable cc-imenu-java-generic-expression.

Attached is my patch which modifies this variables to accept all function definitions and should fix this issue.


Thanks!
Nathaniel Flath
--000e0cd172e6d6db40046efc890c-- --000e0cd172e6d6db4a046efc890e Content-Type: text/x-patch; charset=US-ASCII; name="cc-menus.patch" Content-Disposition: attachment; filename="cc-menus.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fxahn8sz0 aW5kZXggYjE1MWJkMC4uOGE4NzQ0OCAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvY2MtbWVu dXMuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvY2MtbWVudXMuZWwKQEAgLTE0OSwxNyArMTQ5LDE4 IEBAIEEgc2FtcGxlIHZhbHVlIG1pZ2h0IGxvb2sgbGlrZTogYFxcKF9QXFx8X1BST1RPXFwpJy4i KQogKGRlZnZhciBjYy1pbWVudS1qYXZhLWdlbmVyaWMtZXhwcmVzc2lvbgogICBgKChuaWwKICAg ICAgLChjb25jYXQKLSAgICAgICAiWyIgYy1hbHBoYSAiX11bXF1cWy4iIGMtYWxudW0gIl9dK1sg XHRcblxyXSsiIDsgdHlwZSBzcGVjCisgICAgICAgIlsiIGMtYWxwaGEgIl9dW1xdXFsuIiBjLWFs bnVtICJfPD4gXStbIFx0XG5ccl0rIiA7IHR5cGUgc3BlYwogICAgICAgICJcXChbIiBjLWFscGhh ICJfXVsiIGMtYWxudW0gIl9dK1xcKSIgOyBtZXRob2QgbmFtZQogICAgICAgICJbIFx0XG5ccl0q IgogICAgICAgIDs7IEFuIGFyZ3VtZW50IGxpc3QgdGhhdCBpcyBlaXRoZXIgZW1wdHkgb3IgY29u dGFpbnMgYXQgbGVhc3QKLSAgICAgICA7OyB0d28gaWRlbnRpZmllcnMgd2l0aCBvbmx5IHNwYWNl IGJldHdlZW4gdGhlbS4gIFRoaXMgYXZvaWRzCisgICAgICAgOzsgdHdvIHdvcmRzIHdpdGggd2hp dGVzcGFjZSBpbiBiZXR3ZWVuIHRoZW0uICBXb3JkcyBhcmUKKyAgICAgICA7OyBpZGVudGlmaWVy cyBhbmQgPD5AIGNoYXJhY2Vycy4gIFRoaXMgcHJldmVudHMgdXMgZnJvbQogICAgICAgIDs7IG1h dGNoaW5nIGUuZy4gImVsc2UgaWYgKGZvbykiLgogICAgICAgIChjb25jYXQgIihbIFx0XG5ccl0q IgotCSAgICAgICAiXFwoW1xdXFsuLCIgYy1hbG51bSAiX10rIgorCSAgICAgICAiXFwoW1xdXFsu LCIgYy1hbG51bSAiX0A8PiBdKyIKIAkgICAgICAgIlsgXHRcblxyXSsiCiAJICAgICAgICJbXF1c Wy4sIiBjLWFsbnVtICJfXSIKLQkgICAgICAgIltcXVxbLiwiIGMtYWxudW0gIl8gXHRcblxyXSoi CisJICAgICAgICJbXF1cWy4sIiBjLWFsbnVtICJfIFx0XG5cckA8PiBdKiIKIAkgICAgICAgIlxc KT8pIikKICAgICAgICAiWy4sIiBjLWFsbnVtICJfIFx0XG5ccl0qIgogICAgICAgICJ7Igo= --000e0cd172e6d6db4a046efc890e--