unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Master branch broken for MinGW by recent Gnulib update
Date: Mon, 20 May 2024 08:30:09 -0700	[thread overview]
Message-ID: <5ddf7b16-eb70-4698-9f3b-8b20efc81216@cs.ucla.edu> (raw)
In-Reply-To: <86le44acrq.fsf@gnu.org>

On 2024-05-20 05:28, Eli Zaretskii wrote:
> I don't understand these linker errors

u64rol should be declared 'inline' when compiling sha512.c, and 'extern 
inline' when compiling u64.c.

My guess is that a 'make bootstrap' will fix the problem.

If not, what is the output of 'nm -o u64.o sha512.o | grep u64rol'? It 
should be something like this (with more 0s on a 64-bit build):

   u64.o:00000000 T u64rol
   sha512.o:         U u64rol

and the definition in u64.o should satisfy the use in sha512.o. If not, 
please look at the preprocessed output when compiling u64.c. That output 
should contain something like this:

   # 200 "u64.h"
   extern inline u64
   u64rol (u64 x, int n)
   {
     return ((((x) << (n))) | (((x) >> (64 - n))));
   }

and if it doesn't, that's the problem.



  reply	other threads:[~2024-05-20 15:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-20 12:28 Master branch broken for MinGW by recent Gnulib update Eli Zaretskii
2024-05-20 15:30 ` Paul Eggert [this message]
2024-05-20 15:56   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ddf7b16-eb70-4698-9f3b-8b20efc81216@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).