Re: Messages from autogen

[Paul Eggert <eggert@cs.ucla.edu>]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Angelo Graziosi wrote:
> but I haven't a .git directory!

Yes, in that case the intent was to skip the 'git' stuff by default. I never 
test in an environment that lacks 'git' so I didn't run into the problem when 
hacking on autoconf.sh.

I installed the attached, which should fix the problem. Please give it a try 
(from the previous paragraph one can easily see that I have not tested that the 
patch actually fixes the problem :-).

[-- Attachment #2: 0001-autogen.sh-omit-bogus-chatter-if-no-.git.patch --]
[-- Type: text/x-patch, Size: 1482 bytes --]

From 1836e5616699d553eb73b66d1c77135cf8a8e1e9 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 7 Sep 2017 00:10:05 -0700
Subject: [PATCH] autogen.sh: omit bogus chatter if no .git

Problem reported by Angelo Graziosi in:
http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00045.html
* autogen.sh (git_config): Do not execut 'git' if $do_git fails.
---
 autogen.sh | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/autogen.sh b/autogen.sh
index 0d00d56..b3c5f48 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -269,23 +269,23 @@ fi
 
 git_config ()
 {
+    $do_git || return
+
     name=$1
     value=$2
 
     ovalue=`git config --get "$name"` && test "$ovalue" = "$value" || {
-	if $do_git; then
-	    if $git_was_ok; then
-		echo 'Configuring local git repository...'
-		case $cp_options in
-		  --backup=*)
-		    config=$git_common_dir/config
-		    cp $cp_options --force -- "$config" "$config" || exit;;
-		esac
-	    fi
-	    echo "git config $name '$value'"
-	    git config "$name" "$value" || exit
-	fi
-	git_was_ok=false
+       if $git_was_ok; then
+	   echo 'Configuring local git repository...'
+	   case $cp_options in
+	       --backup=*)
+		   config=$git_common_dir/config
+		   cp $cp_options --force -- "$config" "$config" || exit;;
+	   esac
+       fi
+       echo "git config $name '$value'"
+       git config "$name" "$value" || exit
+       git_was_ok=false
     }
 }
 
-- 
2.7.4