From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix some failing tests in BSD systems Date: Mon, 4 Jan 2021 15:10:40 +0200 Message-ID: <5d574d90-34b1-0fb1-8b3a-83e7709eadfc@yandex.ru> References: <83a6tpdiuf.fsf@gnu.org> <5e881738-2df3-d5e3-9a46-bc4304ff4092@yandex.ru> <835z4dcrah.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24536"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: emacs-devel@gnu.org, mardani29@yahoo.es To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 04 14:12:10 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwPeb-0006Af-Vw for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Jan 2021 14:12:09 +0100 Original-Received: from localhost ([::1]:49900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwPeb-0007ev-0w for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Jan 2021 08:12:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwPdL-0006ji-MK for emacs-devel@gnu.org; Mon, 04 Jan 2021 08:10:51 -0500 Original-Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]:39468) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwPdH-0007EE-RT; Mon, 04 Jan 2021 08:10:49 -0500 Original-Received: by mail-ed1-x530.google.com with SMTP id c7so27273813edv.6; Mon, 04 Jan 2021 05:10:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gmmtwrILrMt0ijM11Ikq9uyWiafDe86LXRIGUIEzw/Y=; b=njG7qvMi+t9lQJ0JSbWkfMo1zQNHULI6nHTm8nbywV/aiC80iYqYZiavKj+HpmsV6e AiGn6NmYnovkEdtVKqKRQf1+JdV9nzwLqOFHKwOlNY7wlY5nZ3dRcOcnwgySpxXtNR/d p2oyexwpTbffteC2KCSmAcbvxHreVmF5JPDGctmbvVvebmMCPY2Su1/a0s9BaEMb5otc 0Za5whhhe92BWYS8NS8soCvHNVpMAc3J6VFBmJ2Vrx7HpVb0L0/oxwcCEsJvMJsN7PNE Y+TNpGp781EHd8WfIxv54kB2RS6Upyj9rndenLluBYhBbgSqpkvbHeOzDSyKl58kSy/P BysQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gmmtwrILrMt0ijM11Ikq9uyWiafDe86LXRIGUIEzw/Y=; b=cq3wsPPqs7qry+JpoioeuyiWMJg5ZhBagk2M29MvBJfHQtdRNNTXRwxYkWARt5trZE ydA5S3UP69sIM58T00hWmZnSr9ri93at4w21MCHuHxCAK+y34p1RWJ2PeCkCaMprpzbs LqCcWVmelNhr9rs7qOKVc9QPwyh1V2YtHqtiWc/NlPkDrv8oIpwm4+vuAKTcVUjwIdQ+ 6wTK0pCZUOW4znxoxy6Vvz/miuVr/hXQMUC3igiSQ67PVE4VK17xogIhoGTU5ZqjxQKs 0NiMvEkVN2UqCFKKviWisRErone3JeZBsJnItIkW71Jrf/ZOau7nqG5NwaBx4U9ZlJdz dSBg== X-Gm-Message-State: AOAM531AiA9EVE8D93e6FEPntUNllcyGuc5VgKrmKksL8zxKmET7nivN tYp9lgOJQ2RpXSqzuB2N8IBXyMYxE233Pw== X-Google-Smtp-Source: ABdhPJzSmExz28muvrntUGslMdojBLpu0S87V1mjBfbMX+kxHlMbVKYL4S3qJhikeOB4BDDd+qouYQ== X-Received: by 2002:aa7:d74f:: with SMTP id a15mr71759913eds.344.1609765844272; Mon, 04 Jan 2021 05:10:44 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id e19sm44369715edr.61.2021.01.04.05.10.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jan 2021 05:10:43 -0800 (PST) In-Reply-To: <835z4dcrah.fsf@gnu.org> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::530; envelope-from=raaahh@gmail.com; helo=mail-ed1-x530.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262424 Archived-At: On 04.01.2021 05:30, Eli Zaretskii wrote: >> Cc: emacs-devel@gnu.org >> From: Dmitry Gutov >> Date: Mon, 4 Jan 2021 03:41:20 +0200 >> >> On 03.01.2021 19:35, Eli Zaretskii wrote: >>> Why are we producing file names by concatenation, instead of calling >>> expand-file-name? Wouldn't using the latter solve the problem? Or >>> what did I miss? >> >> While we sometimes do that (expand-file-name is not free, and for >> certain uses its overhead counts), that doesn't seem to be the case here. > > Not sure what you mean: I clearly saw calls to concat in the patch, > both in the old and the new code. What did I miss? The changes you are referring to are both in the test code. There's nothing inherently wrong in using concat in such code, as long as we test what we want to test. >> The double slash here is produced by an external program, not by >> concatenation. > > I understand that much, but expand-file-name removes the double > slashes as part of its job, doesn't it? Yes, so? If you actually meant to suggest an alternative comparison strategy (like in Daniel's latest patch), then I think the test becomes unnecessarily lax. After all, we want to also check how the string "looks" (because the user will see it verbatim), not just what file it points at.