From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] icomplete-vertical Date: Sat, 10 Apr 2021 22:23:25 +0000 Message-ID: <5cf18ab57cbd13b4b1e5@heytings.org> References: <87h7kkwcy1.fsf@posteo.net> <83tuokb0uk.fsf@gnu.org> <87o8er3i8z.fsf@posteo.net> <87blar3glt.fsf@posteo.net> <87im4z1gbc.fsf@mail.linkov.net> <87eefhevye.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32383"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , emacs-devel@gnu.org, Eli Zaretskii , Stefan Monnier To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 11 00:24:34 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVM1q-0008Kg-EK for ged-emacs-devel@m.gmane-mx.org; Sun, 11 Apr 2021 00:24:34 +0200 Original-Received: from localhost ([::1]:43058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVM1p-000802-H6 for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 18:24:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVM0p-0007aZ-99 for emacs-devel@gnu.org; Sat, 10 Apr 2021 18:23:31 -0400 Original-Received: from heytings.org ([95.142.160.155]:37326) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVM0n-0008AG-7w; Sat, 10 Apr 2021 18:23:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1618093406; bh=QyU8wTyQeeoa3aZyUV6UjqFB0qWwSlCOxUQvY8tzWyk=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=awuZ3NxuK/uP8aEkd5MN54+PczT0uStNKhLLTNvwnPvNVmpynS8w/IZPhePl43YNd Ap0lc85AdpilIseSdoXAZo6993zHCb80ljCQO/oXyNejsQg7/dEHMUIIYfhDz1tAtM yRwbZijVMNqd1rcAUwqvGldZIkCQh4TOgRfDZtG7Q/JAGNku3RMFA6rJ1W/x4Wx7WG xkpTTeGl7s6psasfEMYKKlJcD3PXD3b/7oh6RFZbcnVtG8dT57/klutHdzV6KccvfX U7HqF5AIkFb2GFCOGtaE9gJIbL72S94igg5P59wABdURrw/emGKvNQb8tDx+mp7cP6 s8DH7WlGowRAA== In-Reply-To: <87eefhevye.fsf@mail.linkov.net> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267841 Archived-At: > > Good to see that the new branch avoids such hacks. I tested it out, and > everything is nice. After using it a while I noticed that one useful > feature is missing, but it could be added later to not prevent merging > the current version to master now. What is missing is the scrolling > commands that could be bound to C-v and M-v to scroll completions. For > the simplest implementation, this means just to call > icomplete-forward-completions N times where N is the height of the > displayed completions list. > Alas that wouldn't work in all cases (namely when point is not on the first line), in such cases you would not see one or more completion candidates. I plan to do that later, but it needs some care.