From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH) Date: Thu, 29 Apr 2021 18:52:38 +0200 Message-ID: <5c7bc1f8-0dca-ca0a-b719-a5c39acf8745@daniel-mendler.de> References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15819"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gregory Heytings , Dmitry Gutov , Stefan Monnier , "emacs-devel@gnu.org" To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 29 19:23:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcANi-0003zq-NB for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Apr 2021 19:23:18 +0200 Original-Received: from localhost ([::1]:54156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcANh-0006ke-OL for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Apr 2021 13:23:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lc9uU-0000Th-AV for emacs-devel@gnu.org; Thu, 29 Apr 2021 12:53:07 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:34105 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lc9uP-0000Jz-5P for emacs-devel@gnu.org; Thu, 29 Apr 2021 12:53:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9Rp3cS/whl72uZYlJ7hKkcvNWegWacF862Vbb9z/GdA=; b=YUqRcKhtnPuVMnXJFAYIxcbQxO Fg9LE6IXlGbSSd6X0SVDhwUL1EttxoajcPEQiehB72KjmRYZqtDy0NSwa5q8FFgZ6OLcN0ESQQ/Te 0wseb+HFICBwDS+Aa/OUOJIDl+X+L9h5wpk8R2nQH3CG9FFW4ZW//2/tVI/XhYQQkCJ8=; In-Reply-To: <87czudm7bv.fsf@mail.linkov.net> Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268623 Archived-At: On 4/29/21 6:20 PM, Juri Linkov wrote: >> You can try the patch with the following settings and execute >> `xref-find-references` for example (M-?). > > I tried to use your patch to implement grouping for read-char-by-name. > It helped to greatly reduce the size of mule--ucs-names-group > from 30 lines to just 3 lines that is a big win. That's a nice advantage! > OTOH, it highlighted the shortcomings of amalgamating both > grouping and transforming in the same function: > mule--ucs-names-group doesn't need to provide transformation, > because the same affixation-function is used for both > grouping and non-grouping completions. So for such cases > handling an additional arg `transform` is an extra burden: True, but the burden is fairly minor (2 lines). If we go with a separate `group-transform-function`, the complexity of the code of the completion UIs will be increased and it will take a tiny bit more code for the completion tables which provide a transformation. I don't see a convincing advantage in splitting the single feature into two functions `group-sort/transform-function`. As I argued we cannot combine a separate `group-function` and a generic `transform/format-function`, since the group-specific transformation should only be applied when grouping is used. Otherwise the transformation may remove/hide information from the candidate which is supposed to be displayed in the title. Daniel