unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* "Can't find Hunspell dictionary" error (was Re: Emacs pretest 28.0.91 is out)
@ 2022-01-13  7:51 Phil Sainty
  2022-01-13  8:46 ` Robert Pluim
  0 siblings, 1 reply; 17+ messages in thread
From: Phil Sainty @ 2022-01-13  7:51 UTC (permalink / raw)
  To: Robert Pluim; +Cc: Eli Zaretskii, Stefan Kangas, emacs-devel

Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Robert Pluim <rpluim@gmail.com>
> > Debugger entered--Lisp error: (error "Can't find Hunspell dictionary with a
> > .aff affix f...")
> >   signal(error ("Can't find Hunspell dictionary with a .aff affix f..."))
> >   error("Can't find Hunspell dictionary with a .aff affix f...")
> >   ispell-find-hunspell-dictionaries()
> >   ispell-set-spellchecker-params()
> >   ispell-valid-dictionary-list()
> >
> > This is because I have no hunspell dictionaries at all
> 
> So you want to fix this?  I don't mind, but since it's (AFAIU)
> something specific to your installation, is it important to fix on
> the release branch?

While unexpected, it doesn't seem *invalid* to have no dictionaries
installed, so I think it's weird that `ispell-valid-dictionary-list'
triggers (indirectly) an error in this scenario to essentially say
"there were no valid dictionaries", when that's also what a nil return
value would have meant.

`ispell-valid-dictionary-list' or `ispell-set-spellchecker-params'
should perhaps use `with-demoted-errors' to avoid this?

Failing that, I think guarding against this in spelling-tests.el with
`ignore-errors' makes sense.  It's an :unstable test, but it shouldn't
be triggering actual errors.


-Phil




^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2022-01-14 12:02 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-13  7:51 "Can't find Hunspell dictionary" error (was Re: Emacs pretest 28.0.91 is out) Phil Sainty
2022-01-13  8:46 ` Robert Pluim
2022-01-13 10:20   ` Robert Pluim
2022-01-13 10:39     ` Eli Zaretskii
2022-01-13 11:28       ` Phil Sainty
2022-01-13 12:39         ` Eli Zaretskii
2022-01-13 14:05           ` Robert Pluim
2022-01-13 14:42             ` Eli Zaretskii
2022-01-14  1:05               ` Phil Sainty
2022-01-14  7:12                 ` Eli Zaretskii
2022-01-14  9:06                   ` Phil Sainty
2022-01-14 12:02                     ` Eli Zaretskii
2022-01-13 11:26     ` Phil Sainty
2022-01-13 14:23       ` Robert Pluim
2022-01-13 14:38         ` Robert Pluim
2022-01-13 11:57     ` Phil Sainty
2022-01-13 14:30       ` Robert Pluim

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).