From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.devel Subject: "Can't find Hunspell dictionary" error (was Re: Emacs pretest 28.0.91 is out) Date: Thu, 13 Jan 2022 20:51:50 +1300 Message-ID: <5c74e0fb4c651733c0d8072f7cd40d06@webmail.orcon.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36013"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail Cc: Eli Zaretskii , Stefan Kangas , emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 13 08:57:23 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7uz4-0009CO-1J for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Jan 2022 08:57:22 +0100 Original-Received: from localhost ([::1]:39670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7uz2-0005oG-KS for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Jan 2022 02:57:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7utv-0006qK-BX for emacs-devel@gnu.org; Thu, 13 Jan 2022 02:52:05 -0500 Original-Received: from smtp-4.orcon.net.nz ([60.234.4.59]:60167) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7utt-0000W7-24; Thu, 13 Jan 2022 02:52:02 -0500 Original-Received: from [10.253.37.70] (port=28807 helo=webmail.orcon.net.nz) by smtp-4.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1n7uti-000616-Pm; Thu, 13 Jan 2022 20:51:51 +1300 Original-Received: from wlgwil-nat-office.catalyst.net.nz ([202.78.240.7]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Thu, 13 Jan 2022 20:51:50 +1300 X-Sender: psainty@orcon.net.nz X-GeoIP: -- Received-SPF: pass client-ip=60.234.4.59; envelope-from=psainty@orcon.net.nz; helo=smtp-4.orcon.net.nz X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284684 Archived-At: Eli Zaretskii wrote: > > From: Robert Pluim > > Debugger entered--Lisp error: (error "Can't find Hunspell dictionary with a > > .aff affix f...") > > signal(error ("Can't find Hunspell dictionary with a .aff affix f...")) > > error("Can't find Hunspell dictionary with a .aff affix f...") > > ispell-find-hunspell-dictionaries() > > ispell-set-spellchecker-params() > > ispell-valid-dictionary-list() > > > > This is because I have no hunspell dictionaries at all > > So you want to fix this? I don't mind, but since it's (AFAIU) > something specific to your installation, is it important to fix on > the release branch? While unexpected, it doesn't seem *invalid* to have no dictionaries installed, so I think it's weird that `ispell-valid-dictionary-list' triggers (indirectly) an error in this scenario to essentially say "there were no valid dictionaries", when that's also what a nil return value would have meant. `ispell-valid-dictionary-list' or `ispell-set-spellchecker-params' should perhaps use `with-demoted-errors' to avoid this? Failing that, I think guarding against this in spelling-tests.el with `ignore-errors' makes sense. It's an :unstable test, but it shouldn't be triggering actual errors. -Phil