From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: vertico Date: Sat, 10 Apr 2021 12:14:47 +0200 Message-ID: <5beb12bf-ffd4-d4ae-e710-37f118f69c2b@daniel-mendler.de> References: <87im4vglwv.fsf@gnu.org> <838s5q7gkc.fsf@gnu.org> <8614a537-f80b-8263-14b1-63ff4a935e9f@daniel-mendler.de> <83v98u5vwj.fsf@gnu.org> <83tuoe5ujb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12506"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, tsdh@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 10 12:16:05 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVAeq-0003Bl-EG for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 12:16:04 +0200 Original-Received: from localhost ([::1]:53732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVAep-00080a-FV for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 06:16:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVAdi-0007Oe-DA for emacs-devel@gnu.org; Sat, 10 Apr 2021 06:14:54 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:58185 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVAdg-0005Q5-Qd; Sat, 10 Apr 2021 06:14:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=V5lCN3tSuhBKcC54VX5xu54BQymoUiHIRbO7hQ5hnkY=; b=vJ/kBpOtYUZmI0Eomk88PvZYwU uB0yt308Ei/0nEFW7euQFZbA4fVbbLAdQ8kUQTCU1TT4rQIYdyyUygodHXpQrBY/s71JgfzkzLVDB 9DLGYs/lZkPL3SukvLwD9tWGBcDP0YmNwZLJG8atMJm+MjZ0GqK3lYw0XvRR32sye0SU=; In-Reply-To: <83tuoe5ujb.fsf@gnu.org> Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267795 Archived-At: On 4/10/21 12:00 PM, Eli Zaretskii wrote: >> Okay, thanks for clarifying. In Vertico I try hard to avoid modifying >> existing functions. I am sure this issue could be fixed by adjusting the >> `minibuffer-message` function with an advice such that it adds a cursor >> property. Note that Icomplete also does not make these adjustments, so >> maybe there is something else. > > minibuffer-message already does what I described, so I wonder why this > doesn't work in your case. I suggest to step through the code and > compare with the default use in "emacs -Q". If you cannot figure it > out, submit a bug report with a reproduction recipe in "emacs -Q", and > someone will look into it. Ah okay, I see. Then it makes sense to investigate this more thoroughly. >> I think both Tassilo and I agreed that in the context we are discussing >> (vertico+aggressive-completion), the messages are less important and can >> be happily disabled, making this a non-issue/low-priority issue. > > It's up to you; I just wanted to try helping where I can. Sure, I appreciate it. Thank you! I don't know if Icomplete has similar problems with the minibuffer-messages, so maybe it has already been figured out there. Icomplete uses a single overlay for all minibuffers, which does not seem like a good idea given recursive minibuffers (In Vertico I try to isolate the state of every minibuffer session). But there is something else I wonder about - Icomplete installs a pre-command-hook, which removes the overlay and a post-command-hook which puts it back. Daniel Mendler