unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 20fa40d: Improve doc for web pages; reproducible tarballs
Date: Sun, 1 Apr 2018 13:56:49 -0700	[thread overview]
Message-ID: <5be26af7-8a1d-37d2-9fc3-3039863f845d@cs.ucla.edu> (raw)
In-Reply-To: <97lge817tj.fsf@fencepost.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

Glenn Morris wrote:
> This breaks make-dist on platforms where tar does not support --sort=name.

Thanks for reporting that. I installed the attached, which I hope fixes it.

[-- Attachment #2: 0001-Port-make-dist-to-tar-1.27-and-earlier.patch --]
[-- Type: text/x-patch, Size: 1617 bytes --]

From 69e3af0f6df4093c3e587261dbee64c3f749d47f Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 1 Apr 2018 13:53:15 -0700
Subject: [PATCH] Port make-dist to tar 1.27 and earlier

Problem reported by Glenn Morris in:
https://lists.gnu.org/r/emacs-devel/2018-03/msg00984.html
* make-dist: Use --sort=name only if Tar supports it.
---
 admin/make-tarball.txt | 3 ++-
 make-dist              | 4 +++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/admin/make-tarball.txt b/admin/make-tarball.txt
index bdf7b8c..f9ad217 100644
--- a/admin/make-tarball.txt
+++ b/admin/make-tarball.txt
@@ -210,7 +210,8 @@ longer present.
 
 Tar up the generated html_node/emacs/ and elisp/ directories and update
 the files manual/elisp.html_node.tar.gz and emacs.html_node.tar.gz.
-Use GNU Tar as follows so that the tarballs are reproducible:
+Use GNU Tar 1.28 or later so that the tarballs are more reproducible,
+as follows:
 
   cd manual
   tar='tar --numeric-owner --owner=0 --group=0 --mode=go+u,go-w --sort=name'
diff --git a/make-dist b/make-dist
index 48c7fb4..d651e18 100755
--- a/make-dist
+++ b/make-dist
@@ -643,7 +643,9 @@ files=
        *)  gzip_extension= ;;
   esac
   echo "Creating tar file"
-  taropt='--numeric-owner --owner=0 --group=0 --mode=go+u,go-w --sort=name'
+  taropt='--numeric-owner --owner=0 --group=0 --mode=go+u,go-w'
+  tar --sort=name -cf /dev/null $tempparent/$emacsname/src/lisp.h 2>/tmp/out &&
+    taropt="$taropt --sort=name"
   [ "$verbose" = "yes" ] && taropt="$taropt --verbose"
 
   (cd ${tempparent} ; tar $taropt -cf - ${emacsname} ) \
-- 
2.7.4


  reply	other threads:[~2018-04-01 20:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180330231211.6450.29690@vcs0.savannah.gnu.org>
     [not found] ` <20180330231214.7A6F82041C@vcs0.savannah.gnu.org>
2018-03-31 17:19   ` master 20fa40d: Improve doc for web pages; reproducible tarballs Glenn Morris
2018-04-01 20:56     ` Paul Eggert [this message]
2018-04-02 19:13       ` Glenn Morris
2018-04-09 20:36         ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5be26af7-8a1d-37d2-9fc3-3039863f845d@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).