From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: [PATCH] Add user option to disable location in bookmarks Date: Sun, 21 Jun 2020 05:19:47 +0000 (UTC) Message-ID: <5b7b92cf-941b-477b-96ad-f31236ea8127@default> References: <87sgep35cb.fsf@gmail.com> <87blld2x5h.fsf@gmail.com> <062414c6-41f4-4803-9a62-28274825b8e0@default> <87r1u9mfo0.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="95261"; mail-complaints-to="usenet@ciao.gmane.io" To: Jamie Beardslee , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 21 07:20:50 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jmsPS-000Ofl-15 for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Jun 2020 07:20:50 +0200 Original-Received: from localhost ([::1]:54968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmsPR-00072F-28 for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Jun 2020 01:20:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmsOa-0006UM-2I for emacs-devel@gnu.org; Sun, 21 Jun 2020 01:19:56 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:43862) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmsOY-0002Jq-4k for emacs-devel@gnu.org; Sun, 21 Jun 2020 01:19:55 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 05L5HhJx026147; Sun, 21 Jun 2020 05:19:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=REuMGVulTLb2NVZUFu79eQie0te7oMLCpus44S4shik=; b=ytX+HBUgJlHKnaAC3dyMme5we1fgiEozb7VDyLKHceGkr/hTtwSFx0Yu4WmjDOYX4o8o KV+rW40K+zDULZLy3IJVB5AveeGP90I+svM5OhktomXWOEXK26g2EhNRSZ+I74b3LRDg Epg83WaTI8Gt+2C/zitYOGu8UR56XxHRMoUYQZSvLIUWPvP1junBYMpDS4mRI3SjJIJs 4trWCCawEnDGyDVKRDonyhA8QONLUYwLjB80iO6CcIFIsnDlWShYduUXdQSLcVlRTayq ezLAtu42yJhCLmEvArd43rGj40yNL2kOs/Iwk9ejAZNwHgO6i34DAexCce0s1fsQ7Veg 6w== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 31sebba2c1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 21 Jun 2020 05:19:50 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 05L5DPD1050969; Sun, 21 Jun 2020 05:19:50 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 31sv1j6s7r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 21 Jun 2020 05:19:50 +0000 Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 05L5JmwG015512; Sun, 21 Jun 2020 05:19:48 GMT In-Reply-To: <87r1u9mfo0.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5017.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9658 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006210041 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9658 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 phishscore=0 adultscore=0 impostorscore=0 cotscore=-2147483648 mlxscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006210041 Received-SPF: pass client-ip=156.151.31.85; envelope-from=drew.adams@oracle.com; helo=userp2120.oracle.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/21 01:19:52 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -63 X-Spam_score: -6.4 X-Spam_bar: ------ X-Spam_report: (-6.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252480 Archived-At: > >> My patch allows the user to choose whether or not the bookmark record > >> should be in control of the position. > > > > The bookmark record has already chosen that. Just use a different > > kind of record. Why have an option that acts in a blanket manner on > > all bookmarks, to ignore their position? >=20 > I don't see the problem here, surely some users would want to ignore > bookmarks' positions. Positions of all bookmarks, of any type? Maybe there are such users. But my point was that such a shotgun approach isn't needed, to solve the specific save-place problem. Just do it for save-place (and optionally, per a user option). > There isn't a similar built-in library that > doesn't save position so I feel it should be an option provided by > bookmark.el without the user needing to define their own handler. >=20 > > If this is about save-place then save-place should do the right thing. > > See above. If there's an option to be added in that regard, it's a > > save-place option: `save-place-ignore-bookmark-position'. The hook > > function (see above) can move to the save-place place if the option is > > non-nil, and just do nothing if it's nil. >=20 > Okay, well I've attached that patch here. I understand this is skipping > over one of the best features of bookmarks, but I still think it's a > valuable option even without the use of save-place. Yes, that's the idea. (Didn't try it, but a priori LGTM.)