unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Jamie Beardslee <beardsleejamie@gmail.com>, emacs-devel@gnu.org
Subject: RE: [PATCH] Add user option to disable location in bookmarks
Date: Sun, 21 Jun 2020 05:19:47 +0000 (UTC)	[thread overview]
Message-ID: <5b7b92cf-941b-477b-96ad-f31236ea8127@default> (raw)
In-Reply-To: <87r1u9mfo0.fsf@gmail.com>

> >> My patch allows the user to choose whether or not the bookmark record
> >> should be in control of the position.
> >
> > The bookmark record has already chosen that.  Just use a different
> > kind of record.  Why have an option that acts in a blanket manner on
> > all bookmarks, to ignore their position?
> 
> I don't see the problem here, surely some users would want to ignore
> bookmarks' positions.

Positions of all bookmarks, of any type?
Maybe there are such users.  But my point was
that such a shotgun approach isn't needed, to
solve the specific save-place problem.  Just
do it for save-place (and optionally, per a
user option).

> There isn't a similar built-in library that
> doesn't save position so I feel it should be an option provided by
> bookmark.el without the user needing to define their own handler.
> 
> > If this is about save-place then save-place should do the right thing.
> > See above.  If there's an option to be added in that regard, it's a
> > save-place option: `save-place-ignore-bookmark-position'.  The hook
> > function (see above) can move to the save-place place if the option is
> > non-nil, and just do nothing if it's nil.
> 
> Okay, well I've attached that patch here.  I understand this is skipping
> over one of the best features of bookmarks, but I still think it's a
> valuable option even without the use of save-place.

Yes, that's the idea.  (Didn't try it, but a
priori LGTM.)



  reply	other threads:[~2020-06-21  5:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-20 19:27 [PATCH] Add user option to disable location in bookmarks Jamie Beardslee
2020-06-20 21:35 ` Drew Adams
2020-06-20 22:24   ` Jamie Beardslee
2020-06-20 22:50     ` Stefan Monnier
2020-06-20 23:37       ` Drew Adams
2020-06-20 23:34     ` Drew Adams
2020-06-21  0:22       ` Jamie Beardslee
2020-06-21  5:19         ` Drew Adams [this message]
2020-06-21  9:56         ` Basil L. Contovounesios
2020-06-21  9:13       ` Yuri Khan
2020-06-21 18:44         ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b7b92cf-941b-477b-96ad-f31236ea8127@default \
    --to=drew.adams@oracle.com \
    --cc=beardsleejamie@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).