From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jared Finder via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Mouse-hovering over 'mouse-face' overlays/regions on a TTY Emacs Date: Wed, 02 Dec 2020 00:40:01 -0800 Message-ID: <5aff1d6ff795552203292395560a5075@finder.org> References: <838sajle0s.fsf@gnu.org> <83v9dmker4.fsf@gnu.org> <83h7p6kd74.fsf@gnu.org> <837dq2k8ik.fsf@gnu.org> <87eekag0n3.fsf@gmail.com> <83zh2yisdt.fsf@gnu.org> <83o8jdgzgk.fsf@gnu.org> Reply-To: Jared Finder Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_060987589a719443583e8c7d80f05a9a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37442"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Roundcube Webmail/1.3.15 Cc: joaotavora@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 02 10:37:11 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kkOZT-0009dS-FF for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Dec 2020 10:37:11 +0100 Original-Received: from localhost ([::1]:37304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkOZS-0002Lp-BM for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Dec 2020 04:37:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkNgH-0007Pi-7V for emacs-devel@gnu.org; Wed, 02 Dec 2020 03:40:10 -0500 Original-Received: from greenhill.hpalace.com ([2600:3c01::f03c:91ff:fe73:2daa]:54868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkNgF-0005Ko-Aw; Wed, 02 Dec 2020 03:40:09 -0500 Original-Received: from mail.finder.org (greenhill.hpalace.com [IPv6:2600:3c01::f03c:91ff:fe73:2daa]) by greenhill.hpalace.com (Postfix) with ESMTPSA id 6EC73705; Wed, 2 Dec 2020 08:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=finder.org; s=2018; t=1606898401; bh=7a7Aytm14i80ijzTbxV4cTHDSAcZAVLSneGDgch96VI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2iN33mcv9UThjq5EOyvQdhx/bGDZckuzMlSx3GZhIPjz1RqNrLiAp+AaCsGfX4wVU pjM890bmmjL7afRIBvzC6mj7tOMKE3Er6o16O3j80iwfCnXjblWjmLoCeUoyweO3CC FhXMjFy7AnrDHaXhV681d8nzzBAoulQE4v/c+GedWa8aIGrxYWXfxp01Vj8qcWE92P 2uCMeaYX00nmB45xSfeX7IeydQQWDpZCnd8xFanSjL74holH8qKYZa8dZQ4f0f7/xr V5Bvbu6oa6WD91n17sw2HBNCptcEhmxXq5qGwRpf8n+bua1kciDpOpcrC6S79pUrkb frJrlITLhmQMA== In-Reply-To: <83o8jdgzgk.fsf@gnu.org> X-Sender: jared@finder.org Received-SPF: pass client-ip=2600:3c01::f03c:91ff:fe73:2daa; envelope-from=jared@finder.org; helo=greenhill.hpalace.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260173 Archived-At: --=_060987589a719443583e8c7d80f05a9a Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 2020-12-01 10:20 am, Eli Zaretskii wrote: >> Date: Mon, 30 Nov 2020 23:10:54 -0800 >> From: Jared Finder >> Cc: Eli Zaretskii , emacs-devel@gnu.org >> >> I found the following two suspect lines that sound related, but it's >> unclear to me what they're for. Does anyone know what functionality >> they enable? (Note: I have some local changes, so my line numbers may >> be slightly off.) >> >> term.c:4253 >> tty->mouse_highlight.mouse_face_window = Qnil; >> >> xdisp.c:20783 >> gui_clear_window_mouse_face (w); > > They are necessary parts of mouse-highlight implementation, and should > be indeed enabled in all builds nowadays. > >> Additionally, it looks like set-mouse-position and >> set-mouse-pixel-position in frame.c does not behave consistently on >> TTYs >> if Emacs is compiled with window system support vs without. > > You mean, if Emacs is compiled with X _and_ with GPM? Otherwise I > don't think I see the issue. Yes that. Also if none of the flags are defined, then Fselect_frame is not called. This is independent of if GPM is enabled or not. Attached is a patch that addresses the above issues. I was able to verify that this make set-mouse-position and set-mouse-pixel-position select frames if HAS_GPM is not defined. I was not able to notice any difference when always setting mouse_face_window. I'd appreciate if someone could test the changes to set-mouse-position on MSDOS and with window systems enabled as I can not test that environment. -- MJF --=_060987589a719443583e8c7d80f05a9a Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-Remove-incorrect-usage-of-HAVE_GPM.patch Content-Disposition: attachment; filename=0001-Remove-incorrect-usage-of-HAVE_GPM.patch; size=3673 RnJvbSA0MWZhNDdkNDMxNWE5OThlYTExMTZmMGQ5Zjg5OGVlYWFhZDUxYzBiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXJlZCBGaW5kZXIgPGphcmVkQGZpbmRlci5vcmc+CkRhdGU6 IFdlZCwgMiBEZWMgMjAyMCAwMDowNTo1OSAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIFJlbW92ZSBp bmNvcnJlY3QgdXNhZ2Ugb2YgSEFWRV9HUE0uCgoqIHNyYy9mcmFtZS5jIChGc2V0X21vdXNlX3Bv c2l0aW9uLCBGc2V0X21vdXNlX3BpeGVsX3Bvc2l0aW9uKTogQ2FsbApGc2VsZWN0X2ZyYW1lIGlu IGFsbCB0ZXJtaW5hbHMsIGluZGVwZW5kZW50IG9mIGRlZmluZXMuCiogc3JjL3Rlcm0uYyAoaW5p dF90dHkpOiBJbml0aWFsaXplIG1vdXNlX2ZhY2Vfd2luZG93IGZvciBhbGwKdGVybWluYWxzLgoq IHNyYy94ZGlzcC5jICh0cnlfd2luZG93X2lkKTogQ2FsbCBndWlfY2xlYXJfd2luZG93X21vdXNl X2ZhY2UgaW4gYWxsCmNhc2VzLgotLS0KIHNyYy9mcmFtZS5jIHwgMzYgKysrKysrKysrKysrKysr KysrKysrKysrLS0tLS0tLS0tLS0tCiBzcmMvdGVybS5jICB8ICAyICstCiBzcmMveGRpc3AuYyB8 ICAzICstLQogMyBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9zcmMvZnJhbWUuYyBiL3NyYy9mcmFtZS5jCmluZGV4IDE3ZWM0NTVk MmQuLjRiYmNiNzQ2NjcgMTAwNjQ0Ci0tLSBhL3NyYy9mcmFtZS5jCisrKyBiL3NyYy9mcmFtZS5j CkBAIC0yNTc0LDIyICsyNTc0LDI4IEBAIERFRlVOICgic2V0LW1vdXNlLXBvc2l0aW9uIiwgRnNl dF9tb3VzZV9wb3NpdGlvbiwgU3NldF9tb3VzZV9wb3NpdGlvbiwgMywgMywgMCwKICAgLyogSSB0 aGluayB0aGlzIHNob3VsZCBiZSBkb25lIHdpdGggYSBob29rLiAgKi8KICNpZmRlZiBIQVZFX1dJ TkRPV19TWVNURU0KICAgaWYgKEZSQU1FX1dJTkRPV19QIChYRlJBTUUgKGZyYW1lKSkpCi0gICAg LyogV2FycGluZyB0aGUgbW91c2Ugd2lsbCBjYXVzZSBlbnRlcm5vdGlmeSBhbmQgZm9jdXMgZXZl bnRzLiAgKi8KLSAgICBmcmFtZV9zZXRfbW91c2VfcG9zaXRpb24gKFhGUkFNRSAoZnJhbWUpLCB4 dmFsLCB5dmFsKTsKLSNlbGlmIGRlZmluZWQgTVNET1MKKyAgICB7CisgICAgICAvKiBXYXJwaW5n IHRoZSBtb3VzZSB3aWxsIGNhdXNlIGVudGVybm90aWZ5IGFuZCBmb2N1cyBldmVudHMuICAqLwor ICAgICAgZnJhbWVfc2V0X21vdXNlX3Bvc2l0aW9uIChYRlJBTUUgKGZyYW1lKSwgeHZhbCwgeXZh bCk7CisgICAgICByZXR1cm4gUW5pbDsKKyAgICB9CisjZW5kaWYgLyogSEFWRV9XSU5ET1dfU1lT VEVNICovCisjaWZkZWYgTVNET1MKICAgaWYgKEZSQU1FX01TRE9TX1AgKFhGUkFNRSAoZnJhbWUp KSkKICAgICB7CiAgICAgICBGc2VsZWN0X2ZyYW1lIChmcmFtZSwgUW5pbCk7CiAgICAgICBtb3Vz ZV9tb3ZldG8gKHh2YWwsIHl2YWwpOworICAgICAgcmV0dXJuIFFuaWw7CiAgICAgfQotI2VsaWYg ZGVmaW5lZCBIQVZFX0dQTQorI2VuZGlmIC8qIE1TRE9TICovCisKICAgRnNlbGVjdF9mcmFtZSAo ZnJhbWUsIFFuaWwpOworI2lmIGRlZmluZWQgKEhBVkVfR1BNKSAmJiAhIGRlZmluZWQgKEhBVkVf V0lORE9XX1NZU1RFTSkKICAgdGVybV9tb3VzZV9tb3ZldG8gKHh2YWwsIHl2YWwpOwogI2Vsc2UK ICAgKHZvaWQpIHh2YWw7CiAgICh2b2lkKSB5dmFsOwotI2VuZGlmCi0KKyNlbmRpZiAvKiBIQVZF X0dQTSAmJiAhIEhBVkVfV0lORE9XX1NZU1RFTSAqLwogICByZXR1cm4gUW5pbDsKIH0KIApAQCAt MjYxMiwyMiArMjYxOCwyOCBAQCBERUZVTiAoInNldC1tb3VzZS1waXhlbC1wb3NpdGlvbiIsIEZz ZXRfbW91c2VfcGl4ZWxfcG9zaXRpb24sCiAgIC8qIEkgdGhpbmsgdGhpcyBzaG91bGQgYmUgZG9u ZSB3aXRoIGEgaG9vay4gICovCiAjaWZkZWYgSEFWRV9XSU5ET1dfU1lTVEVNCiAgIGlmIChGUkFN RV9XSU5ET1dfUCAoWEZSQU1FIChmcmFtZSkpKQotICAgIC8qIFdhcnBpbmcgdGhlIG1vdXNlIHdp bGwgY2F1c2UgZW50ZXJub3RpZnkgYW5kIGZvY3VzIGV2ZW50cy4gICovCi0gICAgZnJhbWVfc2V0 X21vdXNlX3BpeGVsX3Bvc2l0aW9uIChYRlJBTUUgKGZyYW1lKSwgeHZhbCwgeXZhbCk7Ci0jZWxp ZiBkZWZpbmVkIE1TRE9TCisgICAgeworICAgICAgLyogV2FycGluZyB0aGUgbW91c2Ugd2lsbCBj YXVzZSBlbnRlcm5vdGlmeSBhbmQgZm9jdXMgZXZlbnRzLiAgKi8KKyAgICAgIGZyYW1lX3NldF9t b3VzZV9waXhlbF9wb3NpdGlvbiAoWEZSQU1FIChmcmFtZSksIHh2YWwsIHl2YWwpOworICAgICAg cmV0dXJuIFFuaWw7CisgICAgfQorI2VuZGlmIC8qIEhBVkVfV0lORE9XX1NZU1RFTSAqLworI2lm ZGVmIE1TRE9TCiAgIGlmIChGUkFNRV9NU0RPU19QIChYRlJBTUUgKGZyYW1lKSkpCiAgICAgewog ICAgICAgRnNlbGVjdF9mcmFtZSAoZnJhbWUsIFFuaWwpOwogICAgICAgbW91c2VfbW92ZXRvICh4 dmFsLCB5dmFsKTsKKyAgICAgIHJldHVybiBRbmlsOwogICAgIH0KLSNlbGlmIGRlZmluZWQgSEFW RV9HUE0KKyNlbmRpZiAvKiBNU0RPUyAqLworCiAgIEZzZWxlY3RfZnJhbWUgKGZyYW1lLCBRbmls KTsKKyNpZiBkZWZpbmVkIChIQVZFX0dQTSkgJiYgISBkZWZpbmVkIChIQVZFX1dJTkRPV19TWVNU RU0pCiAgIHRlcm1fbW91c2VfbW92ZXRvICh4dmFsLCB5dmFsKTsKICNlbHNlCiAgICh2b2lkKSB4 dmFsOwogICAodm9pZCkgeXZhbDsKLSNlbmRpZgotCisjZW5kaWYgLyogSEFWRV9HUE0gJiYgISBI QVZFX1dJTkRPV19TWVNURU0gKi8KICAgcmV0dXJuIFFuaWw7CiB9CiAMCmRpZmYgLS1naXQgYS9z cmMvdGVybS5jIGIvc3JjL3Rlcm0uYwppbmRleCBmZWUzYjU1NTc1Li5kZmRjM2JjZTdlIDEwMDY0 NAotLS0gYS9zcmMvdGVybS5jCisrKyBiL3NyYy90ZXJtLmMKQEAgLTQyNDYsOCArNDI0Niw4IEBA IGluaXRfdHR5IChjb25zdCBjaGFyICpuYW1lLCBjb25zdCBjaGFyICp0ZXJtaW5hbF90eXBlLCBi b29sIG11c3Rfc3VjY2VlZCkKIAogI2lmZGVmIEhBVkVfR1BNCiAgIHRlcm1pbmFsLT5tb3VzZV9w b3NpdGlvbl9ob29rID0gdGVybV9tb3VzZV9wb3NpdGlvbjsKLSAgdHR5LT5tb3VzZV9oaWdobGln aHQubW91c2VfZmFjZV93aW5kb3cgPSBRbmlsOwogI2VuZGlmCisgIHR0eS0+bW91c2VfaGlnaGxp Z2h0Lm1vdXNlX2ZhY2Vfd2luZG93ID0gUW5pbDsKIAogICB0ZXJtaW5hbC0+a2JvYXJkID0gYWxs b2NhdGVfa2JvYXJkIChRbmlsKTsKICAgdGVybWluYWwtPmtib2FyZC0+cmVmZXJlbmNlX2NvdW50 Kys7CmRpZmYgLS1naXQgYS9zcmMveGRpc3AuYyBiL3NyYy94ZGlzcC5jCmluZGV4IDc2ZWY0MjBh MzYuLjQ5OGU2ZjEwNjUgMTAwNjQ0Ci0tLSBhL3NyYy94ZGlzcC5jCisrKyBiL3NyYy94ZGlzcC5j CkBAIC0yMDc3OSw5ICsyMDc3OSw4IEBAICNkZWZpbmUgR0lWRV9VUChYKSByZXR1cm4gMAogCQkg ICAgICsgd2luZG93X3dhbnRzX2hlYWRlcl9saW5lICh3KQogCQkgICAgICsgd2luZG93X2ludGVy bmFsX2hlaWdodCAodykpOwogCi0jaWYgZGVmaW5lZCAoSEFWRV9HUE0pIHx8IGRlZmluZWQgKE1T RE9TKQogCSAgZ3VpX2NsZWFyX3dpbmRvd19tb3VzZV9mYWNlICh3KTsKLSNlbmRpZgorCiAJICAv KiBQZXJmb3JtIHRoZSBvcGVyYXRpb24gb24gdGhlIHNjcmVlbi4gICovCiAJICBpZiAoZHZwb3Mg PiAwKQogCSAgICB7Ci0tIAoyLjIwLjEKCg== --=_060987589a719443583e8c7d80f05a9a--