From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make purecopy create hash tables properly Date: Fri, 27 Jan 2017 14:06:46 -0800 Organization: UCLA Computer Science Department Message-ID: <5acadd78-ac09-9510-93a7-9811d3c803a8@cs.ucla.edu> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1485554871 17726 195.159.176.226 (27 Jan 2017 22:07:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 27 Jan 2017 22:07:51 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 To: Vibhav Pant , Emacs Development Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 27 23:07:47 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXEg2-0002Wb-LX for ged-emacs-devel@m.gmane.org; Fri, 27 Jan 2017 23:07:26 +0100 Original-Received: from localhost ([::1]:49042 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXEg8-0006oB-36 for ged-emacs-devel@m.gmane.org; Fri, 27 Jan 2017 17:07:32 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXEfY-0006k1-9z for Emacs-devel@gnu.org; Fri, 27 Jan 2017 17:06:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXEfT-0002gt-C2 for Emacs-devel@gnu.org; Fri, 27 Jan 2017 17:06:56 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:44840) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cXEfT-0002gg-5t for Emacs-devel@gnu.org; Fri, 27 Jan 2017 17:06:51 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 93E5C16006A; Fri, 27 Jan 2017 14:06:47 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id VR1qHIU1NIwu; Fri, 27 Jan 2017 14:06:46 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E4B801600B9; Fri, 27 Jan 2017 14:06:46 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ggD6eyEalFhE; Fri, 27 Jan 2017 14:06:46 -0800 (PST) Original-Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9EE9316006A; Fri, 27 Jan 2017 14:06:46 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211662 Archived-At: Thanks for the patch. It looks like the right thing to do. Could you plea= se fix=20 it up on the following minor ways? * Use GNU style for C code: space between function and paren, braces nest= ed GNU=20 style, etc. Look in neighboring code for examples. * Rewrite make_pure_hash_table so that it uses a loop rather than recursi= on,=20 when it follows the next_weak link. * Create a proper ChangeLog-style commit message. * Send bug-gnu-emacs email containing the patch in 'git format-patch' for= mat,=20 e.g., by using the command 'git send-email'. Please see the "Commit messa= ges"=20 section in CONTRIBUTE for details about the commit message style. Thanks again.