unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Vibhav Pant <vibhavp@gmail.com>, Emacs Development <Emacs-devel@gnu.org>
Subject: Re: [PATCH] Make purecopy create hash tables properly
Date: Fri, 27 Jan 2017 14:06:46 -0800	[thread overview]
Message-ID: <5acadd78-ac09-9510-93a7-9811d3c803a8@cs.ucla.edu> (raw)
In-Reply-To: <CA+T2Sh15CUqGRUto5W6O5JGq1kJWj0w07HX9fMxGiCm9JNZ0bA@mail.gmail.com>

Thanks for the patch. It looks like the right thing to do. Could you please fix 
it up on the following minor ways?

* Use GNU style for C code: space between function and paren, braces nested GNU 
style, etc. Look in neighboring code for examples.

* Rewrite make_pure_hash_table so that it uses a loop rather than recursion, 
when it follows the next_weak link.

* Create a proper ChangeLog-style commit message.

* Send bug-gnu-emacs email containing the patch in 'git format-patch' format, 
e.g., by using the command 'git send-email'. Please see the "Commit messages" 
section in CONTRIBUTE for details about the commit message style.

Thanks again.



  reply	other threads:[~2017-01-27 22:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-27 18:37 [PATCH] Make purecopy create hash tables properly Vibhav Pant
2017-01-27 22:06 ` Paul Eggert [this message]
2017-01-27 23:10 ` Stefan Monnier
2017-01-28 10:25   ` Vibhav Pant
2017-01-28 10:26     ` Vibhav Pant
2017-01-28 14:58     ` Stefan Monnier
2017-01-28 20:06       ` Vibhav Pant
2017-01-29  2:18         ` Stefan Monnier
2017-01-29 17:23       ` Vibhav Pant
2017-01-29 17:58         ` Stefan Monnier
2017-01-29 19:14           ` Vibhav Pant
2017-01-29 19:41             ` Stefan Monnier
2017-01-30 12:43               ` Vibhav Pant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5acadd78-ac09-9510-93a7-9811d3c803a8@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=Emacs-devel@gnu.org \
    --cc=vibhavp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).