From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: "after" variable watchers Date: Tue, 18 May 2021 17:10:47 +0200 Message-ID: <5a8b6fc9-cca8-374c-39f8-3f3d0f83fbca@gmx.at> References: <83lf8du09t.fsf@gnu.org> <3431d752-559a-7d33-e2fb-2d81dd6cc794@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13665"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , npostavs@gmail.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 18 17:35:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lj1kN-0003J6-K0 for ged-emacs-devel@m.gmane-mx.org; Tue, 18 May 2021 17:35:03 +0200 Original-Received: from localhost ([::1]:58648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lj1kM-00082S-L1 for ged-emacs-devel@m.gmane-mx.org; Tue, 18 May 2021 11:35:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj1N2-0002ra-Ey for emacs-devel@gnu.org; Tue, 18 May 2021 11:10:56 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:44229) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj1N0-0001ut-FY; Tue, 18 May 2021 11:10:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1621350649; bh=7wtTLKmUf1tPuUIL2qmL4k5VGE/qd7UxfJjWyZLzDdM=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=OAqVeWoydQbIdY8+QTntuJF1JbAY4SBKdhL+k9xXj+Tw50p1I1VNAm5SkPtcJBO3d dwStdzjnB5+zqLJKwZA36jOXN64IpxsksPhP6EzwNpilNCl56nsoKUJ4r2esB2ve6f ol9Hcs9MKGKuEiSYp+DeFZsJX0QFnnkePMQUDQ44= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([213.142.96.212]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MEFvj-1lb5PJ3hEj-00AJ1Q; Tue, 18 May 2021 17:10:48 +0200 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:dq/DqVexDvmGDo/Oy6uPUQ3ygfzuMlGdu/3l3M5/At+huvq6+tY jUaLwBamDuXF6XPRaMWzSXS05KjR6k8Wx+gugFxuG1/ptLVUQZfAFXK5ShTmfsybJ0nhcGK rYnwkMwUIpDHjY4jG0ylQV0yezVA1CGgCgzKSRRdRTDzSi741yHgBjNFzc9GpO4hv4XsqYt zJ5NtLEX/G5OwVO7NFTLw== X-UI-Out-Filterresults: notjunk:1;V03:K0:3wrL7KVMFls=:S5IvgK6c5rzKXa7gP+ePkt e7QRji0tLk75gT/L+5mlNED9QHDGntD5tAi+5OQPX332Gc7T5p1//ZRT8F4umGdSCuYtskc4s TDSf4WLYmBgW83upf6X+haIMaU75R93i11TuAOjAC9k3vgzyGjUi78PgPq/fPebg+VUf1HWsq VVUqH3r37HEzfpak5Zt/YSKGrIWlk9GRuS6g6cb+0K6UvwO0gCC1ybJ7FDdSohhrQtU29mFdR I/TyZapA+3ZEFYK2qZ6lOWY8GeV8CvaVk8eL7j5+2Bq1J6i6uJvKTP8TsNih7rXOq9OmUaSqt enB0GoXZklvPtRNc2Trke20mtvwBVr0XjkUtRNL/z6fYzibU7cC5dFurwt2OT8umxYedj26sp EJfh5uYdJbtTh1PwB7SjdRn08aJer2CLSbPGsJV2TBzCfUXheS9i0594FM1x+l0uYW5uSR++a Sp6QyuJzVx84Q97EMlQV31pHjJLZnv4t5MuFTJDTykkLFqbJL0bUtKEbl+YZvgCMtb2SSdPcn IJP40qtJAu7RUiGF8alYNizgCTA4aa39lqZWPX0JN0fXCAriu2AQiPE/jSyzz10IZgSd4iyNC uE2BT/h/dKpANlCzkbBL1Sf4MdGiJAEMI2j+j8W1wDbpY/H9POXG98Jc16MB0aLuwva0mhJdT uZBbohDFw/342XCSL2zAz4/Lr3nVMklph4r/MEJT2wH5xlzKa3W95tW6ZMsEQ7tbH9Gob6Qq5 MrN4RBS83f6j7+aa8j+NzjoANcpgaU6Tf8nK5WPoi8NHMk9RAvn6TNFqE3pmCtf/fTW9vRaa Received-SPF: pass client-ip=212.227.15.18; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269464 Archived-At: >> window_updeco_window is called indirectly from all places that change a >> window's decorations, font or size. > > Would it make sense to call it more lazily, e.g. as part of redisplay > (basically, the watchpoints would just set some dirty bits and then at > the beginning of redisplay you'd then run `window_updeco_window` on > those windows with the dirty bit set)? That was my first approach given our current implementation of watch points. I spent a couple of weeks on it but it didn't really work out. Between the time a variable is set and the time the setting is applied, the "realized" values would be inaccurate. These values are, however, needed in too many places before we start redisplaying a window. I do not want to exclude that such a lazy approach could work. But it would require more profound changes to the way window sizes and decorations are processed than the approach based on "after" variable watchers. martin