unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Sungbin Jo <goranmoomin@daum.net>
To: Po Lu <luangruo@yahoo.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [PATCH] Handle sharing Cocoa xwidgets more gracefully
Date: Tue, 4 Oct 2022 11:03:12 +0900	[thread overview]
Message-ID: <5FE28BCB-F5B8-4C37-868A-53DA70638C71@daum.net> (raw)
In-Reply-To: <87zgec1lik.fsf@yahoo.com>

> 2022. 10. 4. 오전 9:26, Po Lu <luangruo@yahoo.com> 작성:
> 
> Some minor formatting comments on the patch below:

Thanks; continuing on the patch itself as bug#58271.

> Thanks; since you seem to be the original author of the xwidget code on
> Mac OS, could you please fix the crash there when an xwidget is deleted
> but remains on-screen?

Are you mentioning the case when the xwidget view is deleted via
‘delete-xwidget-view’? If that’s the case, the patch on bug#58271 will
automatically recreate the xwidget view. Can the xwidget itself get
deleted when a referencing xwidget view still exists in a buffer?

I’m unfortunately not *that* knowledgable on xwidget internals; the very
first original patch was written by Jaesup Kwak, I’ve been slowly
expanding my understandings.

I found that documentation on various parts of xwidgets were very light;
while the functions related to xwidget views are exposed in elisp, seems
like documentation on them were non-existent. I’m still having a hard
time understanding on how the xwidget system is designed to interact
(e.g. it seems from the code that one window cannot contain two xwidget
views pointing the same xwidget – is this a bug or is it working as
designed?); do you have any pointers on this?

Thanks.


  reply	other threads:[~2022-10-04  2:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-03 14:16 [PATCH] Handle sharing Cocoa xwidgets more gracefully 조성빈
2022-10-04  0:26 ` Po Lu
2022-10-04  2:03   ` Sungbin Jo [this message]
2022-10-04  2:41     ` Po Lu
2022-10-04  7:48       ` Sungbin Jo
2022-10-04  8:34         ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5FE28BCB-F5B8-4C37-868A-53DA70638C71@daum.net \
    --to=goranmoomin@daum.net \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).