From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master f9f4f054bc1 1/2: Compare fixnums and floats accurately in value< Date: Thu, 4 Jul 2024 17:51:42 +0200 Message-ID: <5ECE8677-D24F-48AE-AA11-3F5EE84580B2@gmail.com> References: <172010183615.2930.8557271862854647404@vcs2.savannah.gnu.org> <20240704140356.A5E1AC1FB68@vcs2.savannah.gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34068"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 04 17:52:04 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPOke-0008ag-9C for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Jul 2024 17:52:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPOkQ-0007ss-0x; Thu, 04 Jul 2024 11:51:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPOkO-0007sO-GK for emacs-devel@gnu.org; Thu, 04 Jul 2024 11:51:48 -0400 Original-Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPOkM-0001AZ-Nf for emacs-devel@gnu.org; Thu, 04 Jul 2024 11:51:48 -0400 Original-Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-52ea34ffcdaso214391e87.1 for ; Thu, 04 Jul 2024 08:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720108304; x=1720713104; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=VU79bjAN4cmqRFdhjp7Ay2d1DozbH/WNf8v72ySYwlk=; b=GLEPTBKjeI/mqwWI0xoKCmqeVNA06pxZNQQj3j99Weg6RrlCI6h+lOUUNeITRGVd22 gPzSZnmA+TLbFeh+FDnExNNM9gs+Sg7QJhXwKDCRurCyd+wQtfUsKcnvPgP08rwCCmaQ mkI3Ycm1Bc3RzWmgu0WZIcbDG2ATqDvK/er59bWbsVURd56rQMSIwa3YqRydGkj8/tOH UpoNcS1hAKjfydPvxnpxNLO+pLYuj356r/ggYrVJflEuNEpRAkaGMAVAU539hudrHnxL e4QMPBnaz4Rfa0IqNxYqr/zWzyS89HzGg2pLsqOZy1g/0jOmrb5GEDxt4lL/oo+q+Mjx S5qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720108304; x=1720713104; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=VU79bjAN4cmqRFdhjp7Ay2d1DozbH/WNf8v72ySYwlk=; b=bxKRiT450MHD5n1x+eDsWcYOSLMx+k/x3AAveyWy2PnsSgXHWN69NZpFn3+YTA88nO +uptzL40k5xUEMhEHUdFwQVackcm99zbG4lnzFAPj1FzGcZBscmcGP9hp3lhRclIYG8F /ycjSS3w41Y+ErcDqM/XE0rnWTpWmvzSCHRT6wa1eoGPboMYw2mLGsKqdC8IG7aE+2tA z73Kgo1qQbFT8FQOf3SDJrptpEVL8IK4sZ9M/ndm4G/njTjFpK+elHQtNEukM0/Ri9Lq poqrjFENW2jQ3KTDuOsajVjfTzsv3VOuhOwavu/+wqoSWqVnUlN0RD/O89QLtAslvMrh ON3g== X-Gm-Message-State: AOJu0Yx8yHihLF6NfY5u745wozCUMY9IGtAwJz12O2yiliSSpL3h3COj x4IwmPSz3ZqbN8E8ILgnJr3/EHXdx2eAfeOg9SuoL+RW0YhdMKrmtPYnegP5 X-Google-Smtp-Source: AGHT+IFud+OEIBKS/+6rlOPu03pToLfU2E6xZqdIpnkGxBQt4QV93gsMfDmw+YhAcUOT+6TntL4S6g== X-Received: by 2002:ac2:5281:0:b0:52c:dd0c:4c57 with SMTP id 2adb3069b0e04-52ea063a63emr1318788e87.27.1720108304082; Thu, 04 Jul 2024 08:51:44 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-191-82.bredband.tele2.se. [188.150.191.82]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52e7ab3b295sm2453836e87.274.2024.07.04.08.51.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jul 2024 08:51:43 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::12b; envelope-from=mattias.engdegard@gmail.com; helo=mail-lf1-x12b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321329 Archived-At: 4 juli 2024 kl. 17.16 skrev Pip Cet : > Can you add a comment to fixnum_float_cmp explaining that it only = works for fixnums (62 / 30 bits), not for arbitrary EMACS_INTs (64 / 32 = bits)? Or is that totally obvious? Sometimes we need to state the totally obvious! The comment is now a bit = more helpful.