From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: juri@jurta.org, gergely@risko.hu, emacs-devel@gnu.org
Subject: Re: find-file-hook, recenter, scroll-conservatively and save-place
Date: Thu, 31 Jan 2019 19:44:22 +0100 [thread overview]
Message-ID: <5C534206.7020100@gmx.at> (raw)
In-Reply-To: <83y370zymm.fsf@gnu.org>
>> Juri, should we handle this somehow? That is, provide 'window-point'
>> and 'window-start' action alist entries with the former allowing the
>> 'switch-to-buffer-preserve-window-point' logic (among others) and the
>> latter optionally allowing to recenter.
>
> How would you compute window-start in this case so that point is
> centered?
When 'display-buffer' finds a '(window-start . recenter) ALIST entry
it would call 'recenter' after assigning the window buffer.
>> I don't know how 'save-place' could pass these on to the
>> 'pop-to-buffer' call in 'find-file' though. Can you think of any
>> other use cases where these would be helpful?
>
> save-place installs a find-file-hook, which simply calls goto-char.
> All this happens before pop-to-buffer is called.
Which probably means that no 'window-point' entry is needed -
'(window-point . nil) would mean to use the buffer's point as
window-point.
martin
next prev parent reply other threads:[~2019-01-31 18:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 9:46 find-file-hook, recenter, scroll-conservatively and save-place Gergely Risko
2019-01-31 13:46 ` Gergely Risko
2019-01-31 14:43 ` Eli Zaretskii
2019-01-31 15:31 ` Gergely Risko
2019-01-31 13:49 ` martin rudalics
2019-01-31 14:32 ` Eli Zaretskii
2019-01-31 18:44 ` martin rudalics [this message]
2019-01-31 23:47 ` Gergely Risko
2019-02-01 9:05 ` martin rudalics
2019-01-31 20:57 ` Juri Linkov
2019-01-31 22:45 ` Gergely Risko
2019-02-01 9:05 ` martin rudalics
2019-02-02 21:03 ` Juri Linkov
2019-02-03 20:18 ` Juri Linkov
2019-02-01 9:04 ` martin rudalics
2019-02-01 11:18 ` Gergely Risko
2019-02-02 9:30 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C534206.7020100@gmx.at \
--to=rudalics@gmx.at \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gergely@risko.hu \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).