From: martin rudalics <rudalics@gmx.at>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: Current master does not work with sr-speedbar package (W64 build)
Date: Fri, 07 Dec 2018 14:49:56 +0100 [thread overview]
Message-ID: <5C0A7A84.9060106@gmx.at> (raw)
In-Reply-To: <jwv36r979lp.fsf-monnier+gmane.emacs.devel@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
>> Not here. When I remove the offending line it gets compiled. So you
>> probably should invent something more sophisticated ;-)
>
> Hmm... I must be missing something:
>
> emacs-26-0% rm lisp/emacs-lisp/package.elc; make |& grep ELC
> ELC emacs-lisp/package.elc
> emacs-26-0%
>
> this is with a vanilla checkout of the `emacs-26` branch.
>
> Can you show me the patch corresponding to "remove the offending line"?
The offending line is not in the Local Variables section but in the
'insert' call of 'package-quickstart-refresh'.
(insert "\f
;; Local\sVariables:
;; version-control: never
;;\sno-byte-compile: t
;; no-update-autoloads: t
;; End:
"))))
The corresponding Makefile.in condition is
grep '^;.*no-byte-compile: t'
so I see no way that it would byte-compile this.
I attach I patch that fixes this here.
martin
[-- Attachment #2: package.diff --]
[-- Type: text/plain, Size: 496 bytes --]
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index dcede1a..e91001e 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -3570,9 +3570,7 @@ package-quickstart-refresh
;; mistaken for an actual file-local section of package.el.
(insert "\f
;; Local\sVariables:
-;; version-control: never
-;;\sno-byte-compile: t
-;; no-update-autoloads: t
+;; version-control: never\n;;\sno-byte-compile: t\n;; no-update-autoloads: t
;; End:
"))))
next prev parent reply other threads:[~2018-12-07 13:49 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 17:50 Current master does not work with sr-speedbar package (W64 build) Angelo Graziosi
2018-12-04 17:57 ` Eli Zaretskii
2018-12-04 23:31 ` Angelo Graziosi
2018-12-05 18:34 ` Eli Zaretskii
2018-12-05 22:42 ` Angelo Graziosi
2018-12-05 23:07 ` Angelo Graziosi
2018-12-06 0:07 ` Angelo Graziosi
2018-12-06 0:12 ` Angelo Graziosi
2018-12-06 0:54 ` Angelo Graziosi
2018-12-06 6:48 ` Eli Zaretskii
2018-12-06 9:10 ` martin rudalics
2018-12-06 16:12 ` Angelo Graziosi
2018-12-06 6:35 ` Eli Zaretskii
2018-12-06 9:00 ` Angelo Graziosi
2018-12-06 9:17 ` Eli Zaretskii
2018-12-06 11:28 ` Angelo Graziosi
2018-12-06 12:57 ` Eli Zaretskii
2018-12-06 17:49 ` Angelo Graziosi
2018-12-06 18:20 ` Eli Zaretskii
2018-12-06 19:36 ` Angelo Graziosi
2018-12-06 19:47 ` Eli Zaretskii
2018-12-06 20:45 ` Angelo Graziosi
2018-12-06 23:55 ` Angelo Graziosi
2018-12-07 8:04 ` Eli Zaretskii
2018-12-07 8:57 ` Eli Zaretskii
2018-12-07 16:34 ` Angelo Graziosi
2018-12-07 16:44 ` Eli Zaretskii
2018-12-07 6:22 ` Eli Zaretskii
2018-12-07 8:34 ` Angelo Graziosi
2018-12-07 0:36 ` Stefan Monnier
2018-12-07 7:13 ` martin rudalics
2018-12-07 13:00 ` Stefan Monnier
2018-12-07 13:16 ` martin rudalics
2018-12-07 13:26 ` Stefan Monnier
2018-12-07 13:49 ` martin rudalics [this message]
2018-12-10 15:07 ` Stefan Monnier
2018-12-07 13:58 ` Eli Zaretskii
2018-12-07 13:22 ` Eli Zaretskii
2018-12-06 18:45 ` martin rudalics
2018-12-06 19:34 ` Angelo Graziosi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C0A7A84.9060106@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).