From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 134ba45: Allow two mouse functions to work with Rectangle Mark mode Date: Sun, 21 Oct 2018 10:22:27 +0200 Message-ID: <5BCC3743.8040103@gmx.at> References: <20181017063829.3775.67018@vcs0.savannah.gnu.org> <20181017063831.03DCB2044D@vcs0.savannah.gnu.org> <810f1e04-1117-476d-9a7d-d57002609bf8@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1540110057 23989 195.159.176.226 (21 Oct 2018 08:20:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 Oct 2018 08:20:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier , Federico Tedin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 21 10:20:53 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gE8yj-0006C7-G6 for ged-emacs-devel@m.gmane.org; Sun, 21 Oct 2018 10:20:53 +0200 Original-Received: from localhost ([::1]:57965 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gE90q-0004bf-14 for ged-emacs-devel@m.gmane.org; Sun, 21 Oct 2018 04:23:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gE90b-0004aA-K0 for emacs-devel@gnu.org; Sun, 21 Oct 2018 04:22:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gE90W-0005Uw-J4 for emacs-devel@gnu.org; Sun, 21 Oct 2018 04:22:49 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:38515) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gE90W-0005UO-8f for emacs-devel@gnu.org; Sun, 21 Oct 2018 04:22:44 -0400 Original-Received: from [192.168.1.101] ([46.125.250.51]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LiTF6-1fbmyx22yC-00cgts; Sun, 21 Oct 2018 10:22:31 +0200 Original-Received: from [192.168.1.101] ([46.125.250.51]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LiTF6-1fbmyx22yC-00cgts; Sun, 21 Oct 2018 10:22:31 +0200 In-Reply-To: X-Provags-ID: V03:K1:go6+gPwFF25gxqfXur66a3Xh4MgVDU8GmkLYsCjomII/UeBhZIc 6Ey+JQ017eMtdoPDiIAJqq3puNHYS0LvrTk3QdcQCLSYKQGrnIMlLeJI8X69qC87EJQDA4t gndWacl8p1lASldWxvhKsPPRajLQZUjzgNhftJQqHxqs0oen80dLYPzhja4WvZxJINwmyVW r2eGTHnCiPEmJ3UTiqCLg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Tw56PXhPGO4=:QdS2R+wSO8LRDg4e1HPdk9 Gp8KoQ5Lx4vp/yCUodFkPfxD+eCkKtkYqnstg7Dp0lMtrQ7oTdnFYEaddEd/rWhTzK3Y3Qi3B 4m3aDl17yLpD03rn3jk0G61Ds2VhZQZOF3hRAz22lCLlJiuGg+LHqZj2xRPo9aoYq9j7y4J6F aOm0MpjG6XK8uv9RP6rvWha3W5mEORa5zqi5M7Gk5+ggA868KaY5s+qfprGlD4NmrhO4QaxFd mmZ5V7GuoKTg6FfTH2S60Od2UOhKeZYMjGt12xeRperSf5HaSqibDDeY/i99P9T8AfWT0QOAO +ZVgglzfmSDkzpbd4G7ObMF1LC5HkgJvXBGeoEiJFAmBM9YuOAvJkAxWsaQcaqJaQSMdExFiz KY5HFcXzFRci3YV2PQ3sCEx4BQD8IPYnAghHez2beMevL/u7Y/BBwJc0m8+E/M3y4JsPVzXoX LAWWrrANOqUKqPx7K0EGF6aBjQD3ghp3e3wgiNTPI3KZrU6Yt4V/BVRrBySlqOMalZ4fuBE67 rNuxMeDX1iwbwTGHNcaazJCnQzVSyqC+5655tolSHXCq5e8eHHROGkW8RHBaTTYJOuY/CuuDY rcyxW6Yrp04IgUClW3kilmKJAl++xQvcSKNRQrXAzdGv4/neO1icbDL5qp2v99sd/OA+BnYVR l2NVq9WMy69QBbQR+OygGVPdHMDjZ/KgERwqLd37dHih4IZ36Zyrfqzjw6xodvkc1W0iBlDY8 ZZQBAXz0HFL6K4leJYk1bz3s1vIqwGY4QwYcSHcNW5mIN/HwJkhEdXsCGCYViY8wnLeya1P0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230538 Archived-At: > I don't understand enough of the "dragged into itself" test to know what > should be done here. I think part of the issue is that for rectangular > regions, the "insert-for-yank" will actually not just insert, so we > can't just test "is insertion-point inside region-bounds?" (which could > be easily implemented in a generic way). But at the same time, why > should we disallow dragging the rectangle to a place that overlaps its > original location? AFAICT, the drag into itself case is different for contiguous and non-contiguous regions. For the former we want to avoid changing anything because we would clutter undo with actions that remove and re-add the same portion of text at the same position. For rectangles we allow to move the rectangle such that the buffer regions spanned by the beginning of the first and the end of the last region of original and dragged rectangle may overlap while the individual regions do not overlap. martin