From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: JD Smith Newsgroups: gmane.emacs.devel Subject: Re: Small frameset bug Date: Mon, 3 Feb 2020 10:21:03 -0500 Message-ID: <5A3D0764-39C0-4AD5-B257-C2600FB35975@gmail.com> References: <3B26F6D5-7EE3-4523-A7D7-685D869C3C8E@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="34957"; mail-complaints-to="usenet@ciao.gmane.io" Cc: lekktu@gmail.com, emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 03 16:21:48 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iydXn-0008y6-Pb for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Feb 2020 16:21:47 +0100 Original-Received: from localhost ([::1]:43256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iydXm-0006HF-Ra for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Feb 2020 10:21:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56122) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iydX9-00056A-P1 for emacs-devel@gnu.org; Mon, 03 Feb 2020 10:21:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iydX8-0004LC-QG for emacs-devel@gnu.org; Mon, 03 Feb 2020 10:21:07 -0500 Original-Received: from mail-yw1-xc2b.google.com ([2607:f8b0:4864:20::c2b]:33836) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iydX8-0004Kp-MB for emacs-devel@gnu.org; Mon, 03 Feb 2020 10:21:06 -0500 Original-Received: by mail-yw1-xc2b.google.com with SMTP id b186so13966005ywc.1 for ; Mon, 03 Feb 2020 07:21:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=0TBu1wse5pYLQ/ctIa2mq+lc6G6ifZLJ+8/qR/r7XhQ=; b=bT+I5LYUjS1ZQlaM1+IY85n5IP3f0VEohlsCABtIuT/XBpRhBIQAugX0ORtHj4KrMb hl+9crcbdi0sBlSrv+7DLI2YX7cO6d6tWfTPjCbfr0q/oSHje6MrOA4wkQnYg32SZvUY AdOwDtDU0K4nY21Gifl5hkhafx8KvzlcL1zYcR4OdoOE8E4p/6hGI6xVEZnIe0fBFKf1 +j8qClMoJQ9lpGWpS+a3FfOQ1qccwGmV3KMGl4M8qJHIXOQXwtNzTf1ZCL34AwdZU9WV rl1R60KD3qB+L9MVV+sz3fchwbSuuw5nf4u3vPVzafhUoPT4uRSl0HEia6DdMlc0Ojfk jZhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=0TBu1wse5pYLQ/ctIa2mq+lc6G6ifZLJ+8/qR/r7XhQ=; b=oIQoUee1dHfr2fpFL1vi7VzueMX7Z39pYWWky6z3vqs8AeKz3Ugd9ie7gSDMt/IIhs rAIi23fd/NWeTWE6a+WOhu7i0aZAxTJW0Pc1WPlY8kOONd9f7XIqj6RuiV/MjIccgO74 NcA0YGkhg+vpJpBr71Kit5pqSqvvhjgLbECxaGkIVZtuuQ3MoBrkakZFYP1J8bn121Vp ZPJq87gFg42MTGHdvGPWYPndK0fti0mP0B6rDch4Y/zTffFYq7Mv1LFltVl/X0Qs37hG +44YdmfDvq0uTHxii0GdWuYWPeRWYIoSBpEUVtzMy/q6mdnhbS5UmjX6oFk3DUqozEKX 5i4g== X-Gm-Message-State: APjAAAX6VmwLBza9qmETaeAJWMyIxyenypx9yIvssZeIIU1/FYCY94SH TzDuH/9plb5MapAR9fiMc4o= X-Google-Smtp-Source: APXvYqyiN2BpZ9eFkr3Fa9KeUnebrNCVu9NPAt0dcE6Cg+Q2ka1NGe3zIbWwQdCBQ4BsFaH7t++LFw== X-Received: by 2002:a81:8c7:: with SMTP id 190mr503542ywi.294.1580743265980; Mon, 03 Feb 2020 07:21:05 -0800 (PST) Original-Received: from [192.168.0.102] (cblmdm134-228-15-233.buckeyecom.net. [134.228.15.233]) by smtp.gmail.com with ESMTPSA id h184sm8360965ywa.70.2020.02.03.07.21.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Feb 2020 07:21:05 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3608.40.2.2.4) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::c2b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244832 Archived-At: > On Feb 3, 2020, at 10:13 AM, Robert Pluim wrote: >=20 >>>>>> On Mon, 3 Feb 2020 09:55:48 -0500, JD Smith = said: >=20 > JD> In `frameset--minibufferless-last-p`, the destructuring = statements: >=20 > JD> (pcase-let ((`(,hasmini1 ,id-def1) (assq 'frameset--mini (car = state1))) > JD> (`(,hasmini2 ,id-def2) (assq 'frameset--mini (car = state2)))) >=20 > JD> do not function as intended. Since the `assq` always produces = =E2=80=98frameset=E2=80=94mini` as its car, hasmini1/2 are always set to = this symbol. The subsequent `cond` still works as intended to sort = minibufferless frames last: >=20 > JD> (cond ((eq id-def1 t) t) > JD> ((eq id-def2 t) nil) > JD> ((not (eq hasmini1 hasmini2)) (eq hasmini1 t)) > JD> ((eq hasmini1 nil) (or id-def1 id-def2)) > JD> (t t)))) >=20 > JD> but the 3rd and 4th conditions are never met. This may cause = confusion for anyone trying to use the =E2=80=98frameset=E2=80=94mini = frame parameter. >=20 > I guess you=CA=BCre looking in emacs-26? In emacs-27 'cdr' is applied = to > the 'assq' result. Ahah, looks like this has been fixed and documented. Thanks.