From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document' Date: Sun, 17 Dec 2017 18:54:05 +0100 Message-ID: <5A36AF3D.8040406@gmx.at> References: <20171216141055.30854.67661@vcs0.savannah.gnu.org> <20171216141056.8391A24612@vcs0.savannah.gnu.org> <83bmiyslq7.fsf@gnu.org> <83a7yhqrys.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1513533152 588 195.159.176.226 (17 Dec 2017 17:52:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 17 Dec 2017 17:52:32 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 17 18:52:28 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQd6x-00086O-Ro for ged-emacs-devel@m.gmane.org; Sun, 17 Dec 2017 18:52:28 +0100 Original-Received: from localhost ([::1]:55054 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQd8t-00052T-1o for ged-emacs-devel@m.gmane.org; Sun, 17 Dec 2017 12:54:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQd8m-00052O-0d for emacs-devel@gnu.org; Sun, 17 Dec 2017 12:54:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQd8i-0006a5-59 for emacs-devel@gnu.org; Sun, 17 Dec 2017 12:54:20 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:51849) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eQd8h-0006Zr-RH; Sun, 17 Dec 2017 12:54:16 -0500 Original-Received: from [192.168.1.100] ([212.95.5.95]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M4Gup-1fH52A2z7j-00rpiL; Sun, 17 Dec 2017 18:54:09 +0100 In-Reply-To: <83a7yhqrys.fsf@gnu.org> X-Provags-ID: V03:K0:HfAvEW8qLRiLTU0q99h6010QoHn2HRkiflTKuk0Q88L3Z0YSb20 FaBM9IlUcMWxGGg+OvsK8RN2jY1qPsjOrEOoE9b93ET/uDNTpHMiNFrS8yJAzlfCXGQukoY PSMXKItxs8LxbgWt2XIo1au4Lqkna1b17S97+nHGTL3Dd4zbGejTrz8OLjQLacTGkV3esdj mYSlbzv1dKG0b9gbjOFMA== X-UI-Out-Filterresults: notjunk:1;V01:K0:2fZPR+Xqat4=:3CLFw9yQ1YAsTBH1emnyDf 6tEFJU2zB1BQQRSC60rIhD/vfSQlLp8vvtzfCDj1jcdBSWUf4dnG6i5vZSnd/Wv6gRU3wTuYm LRyPlPTekn9X3J+fr5ZKB02FOUWI23IQ0Lca3AZ41OCkrjiEKC8j61fZfmlLHQsT9X6neMJHA pkMeCHuDT9ixO/hsDABxw4/dEXfYaTINNjGKeDKSl6BKzbKQRiVcPj0QsQ5SNPV61FurJmJkq 1ZfKGNRKBtGAnIlG4Z2L3/7j/Xtioko5HdxmSlL+ZooTL7s/vqlC2jwluXeC4xnxN/omtn02x M5N0r7FfiU3VQQUsGTjtNP8FxQxFT/AYQCoYLFVwPBk2pIJwE33X5E36RF6IpW04OSXJqFCiY sr2ybiWNGhEU/YhOSmkChV/Vktslf5P4xmyLooxBX2VS/d96SPLsjj6ag7W6khrfysOjyzBKz X9Si+y7bf0HtxIl3E11UvAacJYntkfJuaDLp2BjIQOZ15hsmxe/0DPkwdUd+YR8YxmTwdEANg j1iUT7ZBEQ4O2njbVltoUfwNAyO5u3GAajy/RoCZ76A/mwPPaT1tJBkCRdz3b9IedPAux++21 0xxnb8O+FP8JuuTk6LzW62yXIdOClXMyk8Kc4C8KUwBYti4ehNMpBXr0dlxZOibxAKEdH+8aB fxA+cEpazNAzMGYWQdY1tytmGzz9yuhTwU04V0Frwqab+97Nx3cHcSQD31EtsHyohvjEr+GbL prf7is/kX/MFWIhaU0d14lqxiZRvZX4680KBnyRtjNMf7g5QkwxL/ACKSg9QnYz1Tlc8BKdR X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221179 Archived-At: > Purely theoretically, you could always do something like > > (with-current-buffer (window-buffer) > (point)) > to get at the value of point at entry into shr-pixel-column, and then > a similar gork before exiting. But is that a good idea? It will slow > down shr-pixel-column, which is already one of the hottest spots in > shr.el's rendering. I don't think Lars will want to talk to me after > that... We could add a new function `buffer-point' to return the position of point in an arbitrary buffer. Moreover IMO `save-window-excursion' already eats much more time and space than `with-current-buffer'. But I think Stefan is correct in the sense that this is a problem with `shr-pixel-column' and the fix should be there. Something like (defun shr-pixel-column () (if (not shr-use-fonts) (current-column) (if (not (get-buffer-window (current-buffer))) (let ((window-point (window-point))) (prog1 (save-window-excursion ;; Avoid errors if the selected window is a dedicated one, ;; and they just want to insert a document into it. (set-window-dedicated-p nil nil) (set-window-buffer nil (current-buffer)) (car (window-text-pixel-size nil (line-beginning-position) (point)))) (set-window-point nil window-point))) (car (window-text-pixel-size nil (line-beginning-position) (point)))))) but maybe I'm completely misunderstanding the problem at hand. martin