From: martin rudalics <rudalics@gmx.at>
To: Paul Eggert <eggert@cs.ucla.edu>,
Stefan Monnier <monnier@IRO.UMontreal.CA>,
emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-26 9bf66c6: Don't run FOR_EACH_FRAME when there's no frame left (Bug#29961)
Date: Sat, 16 Dec 2017 10:42:43 +0100 [thread overview]
Message-ID: <5A34EA93.1050501@gmx.at> (raw)
In-Reply-To: <cdca81cd-ea75-5b04-40e5-31c11266d461@cs.ucla.edu>
> I recognized callers that either --enable-gcc-warnings complained
> about (because code after the FOR_EACH_FRAME loop clearly had
> undefined behavior unless the loop iterated at least once),
Which ones were these? Neither next_frame nor prev_frame exhibit such
behavior IMO.
> and
> callers where historically there was an eassert that checked the
> assumption.
How far did you go back in history?
> check_glyph_memory doesn't fall into either category; and
> now that I look at its implementation it's clear that
> check_glyph_memory is not making the assumption.
Then you should have reverted that change too. I've done that now.
Thanks, martin
next prev parent reply other threads:[~2017-12-16 9:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171215073120.7671.79446@vcs0.savannah.gnu.org>
[not found] ` <20171215073122.52703204D3@vcs0.savannah.gnu.org>
2017-12-15 16:23 ` [Emacs-diffs] emacs-26 9bf66c6: Don't run FOR_EACH_FRAME when there's no frame left (Bug#29961) Stefan Monnier
2017-12-15 17:13 ` Paul Eggert
2017-12-15 18:17 ` martin rudalics
2017-12-15 19:09 ` Paul Eggert
2017-12-16 9:42 ` martin rudalics [this message]
2017-12-17 0:50 ` Paul Eggert
2017-12-17 10:46 ` martin rudalics
2017-12-18 0:39 ` Paul Eggert
2017-12-18 7:26 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A34EA93.1050501@gmx.at \
--to=rudalics@gmx.at \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).