From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation Date: Sat, 10 Dec 2016 12:14:41 +0200 Message-ID: <59e902d2-e8b4-63e3-f780-af24cdf50a74@yandex.ru> References: <874m2q1oca.fsf@gmail.com> <4707af57-53ae-9b10-686a-1ca0864b9abb@yandex.ru> <87h96cr2su.fsf@secretsauce.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1481364988 9937 195.159.176.226 (10 Dec 2016 10:16:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Dec 2016 10:16:28 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 Cc: emacs-devel@gnu.org, Tino Calancha To: Dima Kogan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 10 11:16:23 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFehZ-0001OC-AI for ged-emacs-devel@m.gmane.org; Sat, 10 Dec 2016 11:16:21 +0100 Original-Received: from localhost ([::1]:51073 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFehd-0004PX-7S for ged-emacs-devel@m.gmane.org; Sat, 10 Dec 2016 05:16:25 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFeh4-0004PS-Tc for emacs-devel@gnu.org; Sat, 10 Dec 2016 05:15:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cFegz-0003Fv-T1 for emacs-devel@gnu.org; Sat, 10 Dec 2016 05:15:50 -0500 Original-Received: from mail-wm0-f44.google.com ([74.125.82.44]:35984) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cFegz-0003Fq-LZ for emacs-devel@gnu.org; Sat, 10 Dec 2016 05:15:45 -0500 Original-Received: by mail-wm0-f44.google.com with SMTP id g23so7631681wme.1 for ; Sat, 10 Dec 2016 02:15:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KUG6pDBmjXkslVNu8wrlCbd1jJjDeuVPB2cv3++CkVM=; b=H/C9zlhX+y/cO7COEHBd82VX79m95lc0KWHgIBPEU/g0E84ZTgFHCPatkkXA2nbCp1 Q7GL5TSMbb74EJ+IQCDikWHDbArdV2fvqlk7syPBMWU2xwCAS7QSWxTpt4UIi4479qR7 SHlsYWUehYNPzX4M/K3sx9E/qj9HRU1epAN30csCQ/6s2RXCelITFVHW0rtkO3Kard0c E9MXcxtjOvbd73tp9wPwiGQNujguSptcZYmRVodQQafNFH4u/7i/4SAi/R3O2xVwaZFd PhjT6JCoDX4HKtBKnmsfvgGqs0I6Xy+ABoC/eTFFAx2QK8vUNKsC8SHq9JbThFDL8gJB kEdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KUG6pDBmjXkslVNu8wrlCbd1jJjDeuVPB2cv3++CkVM=; b=iIXcAeQhwENjMQA3VWlzcD1jPwOr5J8VeK1coGcT36VnSLMO6XjEvJ9g1qRwo6EYpq 1xmWF9s0Fo83oXhxYZtiA9vqTc3PLiACjL1lnSuFXIJ1wnyW31ShgJAWDvUKaBO1l6nq 0J/DJaTBoIgb9kMKJQ6Uymi+OdWNgGb0bZ5pTCjBqXtv3UZLzySrNQiCyiy4TP1aiCxX fV/o/OEX3CwIz2mEQR3D3YZT9jKgZe74sDQ7T73DTVapS7hpjWBi76rrZvMgkaq0DMZB 13TrKN3JTQnaHzo2m8Q3vp96Atg1roEGS6fmZgN764uJO7lP8Y2a8ZA0Yx83JKZubdGH u8sw== X-Gm-Message-State: AKaTC015DlkC0Tpc8Sez5xxS5aSug0fjMj5gpKdBKOFdJf0r/VjPW4uS13oDh2nI6ygEFA== X-Received: by 10.28.32.150 with SMTP id g144mr2118643wmg.46.1481364884349; Sat, 10 Dec 2016 02:14:44 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id c202sm3262900wme.1.2016.12.10.02.14.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Dec 2016 02:14:43 -0800 (PST) In-Reply-To: <87h96cr2su.fsf@secretsauce.net> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 74.125.82.44 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210226 Archived-At: On 10.12.2016 03:27, Dima Kogan wrote: > I'm unclear about what the complaint is. Both the old and new behaviors > made the auto-refinement do its thing. Is the complaint that the point > no longer moves to the end (and if so, why is that "right"?) or is the > "ding" the "problem? Sorry, let me clarify. The first complaint is that, yes, point doesn't move to the end anymore. Foremost, I'm simply used to the old behavior. Second, I'm not sure how to implement on-demand refining of the first hunk in a sane fashion without it, see below. Third, it's simply handy if the first hunk is taller than the height of the window, I would navigate to its end to examine it. Fourth, I'd see the end of the buffer myself before the next pressing of `n' invokes a "ding". The second complaint is that the command does a "ding" (informing me that I did something wrong), and then proceeds to do something useful: refining the hunk. > OK. The logic in place is to auto-refine the hunk at point after a > motion, which is why you're seeing this behavior. Are you seeing this > issue only with the first hunk in a buffer and only when you first load > such a buffer? Yes. > If so, an auto-refinement call from a diff-mode-hook > would solve this. Sounds reasonable, or are such things frowned-upon? What if the first hunk is big and refining takes a lot of time? As it is now, I can make the choice to refine or not myself. If `diff-mode-hook' does that, I won't even see the diff before refining is done.