From: Dmitry Gutov <dgutov@yandex.ru>
To: Dima Kogan <lists@dima.secretsauce.net>
Cc: emacs-devel@gnu.org, Tino Calancha <tino.calancha@gmail.com>
Subject: Re: [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation
Date: Sat, 10 Dec 2016 12:14:41 +0200 [thread overview]
Message-ID: <59e902d2-e8b4-63e3-f780-af24cdf50a74@yandex.ru> (raw)
In-Reply-To: <87h96cr2su.fsf@secretsauce.net>
On 10.12.2016 03:27, Dima Kogan wrote:
> I'm unclear about what the complaint is. Both the old and new behaviors
> made the auto-refinement do its thing. Is the complaint that the point
> no longer moves to the end (and if so, why is that "right"?) or is the
> "ding" the "problem?
Sorry, let me clarify.
The first complaint is that, yes, point doesn't move to the end anymore.
Foremost, I'm simply used to the old behavior. Second, I'm not sure how
to implement on-demand refining of the first hunk in a sane fashion
without it, see below.
Third, it's simply handy if the first hunk is taller than the height of
the window, I would navigate to its end to examine it. Fourth, I'd see
the end of the buffer myself before the next pressing of `n' invokes a
"ding".
The second complaint is that the command does a "ding" (informing me
that I did something wrong), and then proceeds to do something useful:
refining the hunk.
> OK. The logic in place is to auto-refine the hunk at point after a
> motion, which is why you're seeing this behavior. Are you seeing this
> issue only with the first hunk in a buffer and only when you first load
> such a buffer?
Yes.
> If so, an auto-refinement call from a diff-mode-hook
> would solve this. Sounds reasonable, or are such things frowned-upon?
What if the first hunk is big and refining takes a lot of time?
As it is now, I can make the choice to refine or not myself. If
`diff-mode-hook' does that, I won't even see the diff before refining is
done.
next prev parent reply other threads:[~2016-12-10 10:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 12:07 [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation Tino Calancha
2016-11-30 0:03 ` Noam Postavsky
2016-11-30 14:22 ` Dmitry Gutov
2016-11-30 14:31 ` Stefan Monnier
2016-11-30 14:34 ` Dmitry Gutov
2016-11-30 15:07 ` Stefan Monnier
2016-12-10 1:27 ` Dima Kogan
2016-12-10 10:14 ` Dmitry Gutov [this message]
2016-12-10 17:27 ` Dima Kogan
2016-12-11 11:07 ` Dmitry Gutov
2016-12-12 7:28 ` Dima Kogan
2016-12-16 1:05 ` Dmitry Gutov
2016-12-20 2:22 ` Tino Calancha
2016-12-20 7:31 ` Dima Kogan
2016-12-25 6:52 ` Dima Kogan
2016-12-25 9:48 ` Tino Calancha
2016-12-25 9:58 ` Tino Calancha
2016-12-25 14:10 ` Dmitry Gutov
2016-12-06 2:03 ` Mark Oteiza
2016-12-07 7:29 ` Dima Kogan
2017-01-06 2:58 ` Mark Oteiza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59e902d2-e8b4-63e3-f780-af24cdf50a74@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=lists@dima.secretsauce.net \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).