unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Qiantan Hong <qhong@mit.edu>
To: Emacs Devel <emacs-devel@gnu.org>
Subject: Question: add-face-text-property for 'font-lock-face?
Date: Sun, 29 Aug 2021 04:36:49 +0000	[thread overview]
Message-ID: <59E4B9A5-6C95-4A21-BE95-B071E90EA892@mit.edu> (raw)
In-Reply-To: B73E855F-7E55-4217-BD43-E1272939E491@mit.edu

That’s an option, but I’m worried about performance because crdt-visuallize-author-mode
need to color code the whole document and that might be too many overlays.
Maybe one can lazily create overlay for visible part only but I feel like
at that point I’ll probably just reinvent an adhoc add-font-lock-face-text-property in Elisp.

> On Aug 28, 2021, at 9:24 PM, Yuan Fu <casouri@gmail.com> wrote:
> 
> 
> 
>> On Aug 28, 2021, at 9:13 PM, Qiantan Hong <qhong@mit.edu> wrote:
>> 
>> Users of crdt.el report that crdt-visualize-author-mode (which use font-lock-face to color code author of texts)
>> conflict with faces from other modes. Apparently there are more than 1 mode which sets this text property.
>> 
>> Is there some way to add-face-text-property to 'font-lock-face property, 
>> i.e. adding new face attributes instead of overwriting any existing face?
>> add-face-text-property doesn’t seem to work because 'font-lock-face will just override ‘face.
>> 
>> Best,
>> Qiantan
>> 
> 
> Is there anything preventing you from using overlays? They seem to be perfect for the job.
> 
> Yuan

  parent reply	other threads:[~2021-08-29  4:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-29  4:13 Question: add-face-text-property for 'font-lock-face? Qiantan Hong
2021-08-29  4:24 ` Yuan Fu
     [not found]   ` <B73E855F-7E55-4217-BD43-E1272939E491@mit.edu>
2021-08-29  4:36     ` Qiantan Hong [this message]
2021-08-30  8:22       ` Ihor Radchenko
     [not found]     ` <945E4D23-3D8C-45AB-9C10-992638A30607@gmail.com>
2021-08-29  4:47       ` Qiantan Hong
2021-08-29 23:50         ` Stefan Monnier
2021-08-29  7:05 ` Eli Zaretskii
2021-08-29  7:19   ` Qiantan Hong
2021-08-29  7:49     ` Eli Zaretskii
2021-08-29 16:15       ` Clément Pit-Claudel
2021-08-29 21:13         ` Qiantan Hong
2021-08-29 23:47           ` Stefan Monnier
2021-08-30  0:41             ` Qiantan Hong
2021-08-30  8:18             ` Ihor Radchenko
2021-08-29 16:13 ` Clément Pit-Claudel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59E4B9A5-6C95-4A21-BE95-B071E90EA892@mit.edu \
    --to=qhong@mit.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).