.deps/ and .gitignore?

.deps/ and .gitignore?

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

Was the attached patch actually needed? As far as I can see, Emacs builds should 
no longer generate or use .deps subdirectories (as of March 17, roughly - when 
we switched away from Automake). If you have an old .deps subdirectory lying 
around from March-or-earlier builds, you should just remove it.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-.gitignore-Add-.deps.patch --]
[-- Type: text/x-patch; name="0001-.gitignore-Add-.deps.patch", Size: 485 bytes --]

From f1ed31a8f5c6f19aa5e119e670533241c6375945 Mon Sep 17 00:00:00 2001
From: Eli Zaretskii <eliz@gnu.org>
Date: Fri, 28 Jul 2017 12:38:22 +0300
Subject: [PATCH] ; * .gitignore: Add .deps/.

---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 9229297..05a8d6b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -112,6 +112,7 @@ lisp/subdirs.el
 
 # Dependencies.
 deps/
+.deps/
 
 # Logs and temporaries.
 *.log
-- 
2.7.4

Re: .deps/ and .gitignore?

[Eli Zaretskii]

> Cc: Emacs Development <Emacs-devel@gnu.org>
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Sat, 29 Jul 2017 00:08:34 -0700
> 
> Was the attached patch actually needed?

"git status" suddenly started to show that directory as "??"
yesterday, so I presumed it was some new feature of Gnulib, not yet
reflected in .gitignore.

> As far as I can see, Emacs builds should no longer generate or use
> .deps subdirectories (as of March 17, roughly - when we switched
> away from Automake).

Yes, but I see now that you only removed .deps from .gitignore 2 days
ago, which would explain why I suddenly started seeing it.  May I
suggest that in the future you accompany that by posting here an
advice to make sure the directory is removed?

> If you have an old .deps subdirectory lying 
> around from March-or-earlier builds, you should just remove it.

OK, done, and the commit reverted.

Thanks.

Re: .deps/ and .gitignore?

[martin rudalics]

 > If you have
 > an old .deps subdirectory lying around from March-or-earlier builds,
 > you should just remove it.

This is confusing.  Do I remove the .deps/ subdirectory or the src/lib/
one?  It's the latter here that gets marked as untracked.

martin

Re: .deps/ and .gitignore?

[Eli Zaretskii]

> Date: Sat, 29 Jul 2017 10:00:45 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: Emacs Development <Emacs-devel@gnu.org>
> 
>  > If you have
>  > an old .deps subdirectory lying around from March-or-earlier builds,
>  > you should just remove it.
> 
> This is confusing.  Do I remove the .deps/ subdirectory or the src/lib/
> one?

The lib/.deps/ one.

> It's the latter here that gets marked as untracked.

??? There's no src/lib/ directory here.

Re: .deps/ and .gitignore?

[martin rudalics]

These are in my build directories so git won't flag them separately.

 >> It's the latter here that gets marked as untracked.
 >
 > ??? There's no src/lib/ directory here.

Then mine is probably from a very old build I never cleaned up.  Funny
that it got now flagged for the first time as


Untracked files:
   (use "git add <file>..." to include in what will be committed)

	dbg/
	opt/
	src/lib/

nothing added to commit but untracked files present (use "git add" to track)


where dbg/ and opt/ are my build directories on Windows.

Thanks, martin

Re: .deps/ and .gitignore?

[Paul Eggert]

Eli Zaretskii wrote:
> May I
> suggest that in the future you accompany that by posting here an
> advice to make sure the directory is removed?

Sure, that should be easy.