From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Time to merge scratch/correct-warning-pos into master, perhaps? Date: Sat, 22 Jan 2022 18:01:20 +0000 Message-ID: <58bb8030d5ec3a6bde9f@heytings.org> References: <83mtjwzwkb.fsf@gnu.org> <87r198ytog.fsf@gnus.org> <87zgnvyb5y.fsf@gnus.org> <87bl03j10s.fsf@gnus.org> <9D116A4B-622F-4C80-83E6-2CDD7ED9AD25@acm.org> <58bb8030d532070ed420@heytings.org> <838rv7mzn4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40557"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattiase@acm.org, larsi@gnus.org, emacs-devel@gnu.org, monnier@iro.umontreal.ca, acm@muc.de To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 22 19:03:01 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBKj7-000AMZ-5P for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Jan 2022 19:03:01 +0100 Original-Received: from localhost ([::1]:57830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBKj5-0003UW-UW for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Jan 2022 13:02:59 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57724) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBKiA-0002hg-Qp for emacs-devel@gnu.org; Sat, 22 Jan 2022 13:02:03 -0500 Original-Received: from heytings.org ([95.142.160.155]:37012) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBKi6-0007mB-1d; Sat, 22 Jan 2022 13:01:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1642874481; bh=LbqmXbUVWOPbAA0bZJHZyuhz3kEe2PfCB+y+/L/E8j4=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=6FZNe3vLg6WLrvgUtge71ylwpipV8/CnXLEoprpF1Iqmo+XwAotxpV7ky95/mfjT6 u+W0Nw8YsUgWvMX89N3AV4jXYwgrdXH3ZbYjZfbC9Mfqadw9wEpcg7zc+Z0jlaqGKV ALr3Jk4xoZ4gOi3AyJtrJKdzMTOhNV5btMG0ph5Oac1q88vlVYP2+t5XCFPyW7w+8h 9Gqteli/zzlsLG4fGhmSb6Qxt+eARvnSJEf/sGJF01vCVEz7oTbwTFt8SzTScY0F1d cG3ig9D5KVPEMc6ezUt7W96+NKDgVwJOz5TEWOCgKL377jcpY+IvH6Llv2BcLmsXPI nfNkzgsxSsBdA== In-Reply-To: <838rv7mzn4.fsf@gnu.org> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285220 Archived-At: >> I don't know what benchmarks would be representative of actual elisp >> usage, but on my build machine both make bootstrap and make check are >> consistently ~8% slower on correct-warning-pos vs master: >> >> make -j1 bootstrap: 649s vs 596s >> make -j4 bootstrap: 257s vs 238s >> make -j8 bootstrap: 198s vs 183s >> >> make -j1 check: 178s vs 162s >> make -j4 check: 44s vs 40s >> make -j8 check: 26s vs 24s > > That's consistent with what was reported at the beginning of this thread > (~7% slowdown). Byte compilation is expected to be slightly slower with > this change. > But make check does a lot more than byte compilation, or am I missing something?