From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: Recent pcase changes Date: Thu, 4 Mar 2021 12:30:58 +0100 Message-ID: <586BC11A-0E1F-48ED-B69D-0ED2E809A0DE@acm.org> References: <7c26cf68-90d6-a36c-59d9-0d737d1ff143@inventati.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34902"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Manuel Uberti Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 04 12:31:54 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHmCv-0008vo-Bi for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 12:31:53 +0100 Original-Received: from localhost ([::1]:54756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHmCu-0005WM-DC for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 06:31:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHmC9-00055D-MG for emacs-devel@gnu.org; Thu, 04 Mar 2021 06:31:06 -0500 Original-Received: from mail204c50.megamailservers.eu ([91.136.10.214]:59158 helo=mail193c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHmC7-0001gz-EY for emacs-devel@gnu.org; Thu, 04 Mar 2021 06:31:05 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1614857461; bh=SMzpI9HsQ4fZCfN/ty/qCNAl0JaLMuRQ1zzlgr6r09A=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=MZNLmWpYuNMdByK+oQ2155wBDaxupzX+kG4Y5pYMXQOVGG57mQr3UkVMLgAtEarXM FlgpckyKlFI2FKF2qJ96HzbIfYYj3ZXS127xcFBZjXg31qaZxYkAIGjcv8QyLDOBXT a8m9+GsqpIJnxi5Ls3LMBRwb0LVAb8x39BkUTeDQ= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail193c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 124BUxDn018859; Thu, 4 Mar 2021 11:31:00 +0000 In-Reply-To: <7c26cf68-90d6-a36c-59d9-0d737d1ff143@inventati.org> X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A742F15.6040C4F5.001C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=e/d4tph/ c=1 sm=1 tr=0 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=ODn1ZDwwAAAA:8 a=wYV_7giD6bX8FPsznfoA:9 a=CjuIK1q_8ugA:10 a=w60aWSXYNp0UC2dSORM4:22 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.10.214; envelope-from=mattiase@acm.org; helo=mail193c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265943 Archived-At: 4 mars 2021 kl. 11.06 skrev Manuel Uberti : > By looking at clojure-mode code I see it sets `lisp-indent-function' = to > `clojure-indent-function', which makes use of `pcase'. More = specifically, this > is what it does at line 1497 of clojure-mode.el: >=20 > (pcase method > ((or (pred integerp) `(,method)) Now all variables in an `or`-pattern are always bound, to nil if nothing = else. Try: ((or (pred integerp) `(m)) (let ((method (if (integerp method) method m))) ...