From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Bruno Haible Newsgroups: gmane.emacs.devel Subject: Re: Android port Date: Sun, 06 Aug 2023 17:46:27 +0200 Message-ID: <5837029.DyV9NtORJm@nimes> References: <1428589171.162865.1691134964773@mail1.libero.it> <3469960.ipicrQNo7v@nimes> <83h6pcp5rb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28156"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, eggert@cs.ucla.edu, angelo.g0@libero.it, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 06 17:47:27 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qSfyZ-00075Q-9C for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Aug 2023 17:47:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSfxu-0004lL-JV; Sun, 06 Aug 2023 11:46:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSfxs-0004ii-Vi for emacs-devel@gnu.org; Sun, 06 Aug 2023 11:46:45 -0400 Original-Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.164]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSfxq-0001Cz-RK; Sun, 06 Aug 2023 11:46:44 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1691336787; cv=none; d=strato.com; s=strato-dkim-0002; b=qOw411EobuuIQjg38Gj2QFD46AYU1h+f/B6OLid+gWeck2F0yPj09O9NUL0hadYSrC DxTOhvOPL/LCy5E1BYtylen6rCyAVBb5dzmXSVc67IpuHhoL8poQ2PdcMJ2cTmm6x4rU mYc3BjRFu5SM6zHz4lYLlQW2biNIFUq3wGC13PzF/qErh00kQQXwFn38HsVWuUZfXv7L emVrQ8A+QSuqQi5nyWwc9pgBYoT/sxhUA239ywl9eGtT6WA+detZTr0whYwgr9uHMMzq dRTTp1q6sd7L+qCkvoP9obC6dprKTXcFPlVXJ8CxpdDNoYV0LIavSdzbiPr4I/VaT+/f miBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1691336787; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=gx0fKX0tZl3DLAfbvoDV0LGFwhRUjufHlGm7f7/tUYA=; b=Pgg+sGpHPEcAtrdAMjTit6VO5JAuYYe85Qd4z7vDHqKOR1YECgIJI36H+0vlaN3SrI LoRsPQMxRsBbKqdlhmBnJ8ke4eaG3ON0Rddhlpy2B3JYwruJZ/ckZYm+hYULPr6ZUj+w WiJhndD6tIVrXKgTpfzGhAD9GopE2Be0HpuembNbJ33g5qKguYPXl1GAiZgqAU6xVRig MBxqMujeHZaMJlH78VwM0Ts4nLyw8f6KCzJhCwG88m/g/mw1zSZ1FKFTNMkc27K5vz6l QPodHyo49pmdgdSx8tbhant35fZW64KPKZyjCVz609UzcG6iO8NofSIyUfprDJrsMdKy 069Q== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1691336787; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=gx0fKX0tZl3DLAfbvoDV0LGFwhRUjufHlGm7f7/tUYA=; b=F3McGJ5BM0rQP3WzeIfw7mBgqXnF+/TdVIRewQRJaDtuf8SeH4QNEZwHCLLF01axNu MNTszr+lBqQ5AOKWu6ouj8gysi4yCCds2C2uiugyvqSd1ZHf+y+iOwV/eYKDsPb28afH KdD5fVd72PiVXb/+Y6FPX5VKIudP+vOQCcW/7ebUwKAxwjJhMMrZHq+farj+JT4AylDb OPjJl5JMrJr9mEldPOR2iKrO/9O5f7liHydEwiXR6ZGozC6T/kFXNqGBhgxNpWkSkfPn 1kpQjvPGkpwPSivaMQmNez5j57hwrQlAhQSfDOD/h66Ld1llUbuMsq9g7PZm9ydFrcpy rZ1A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1691336787; s=strato-dkim-0003; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=gx0fKX0tZl3DLAfbvoDV0LGFwhRUjufHlGm7f7/tUYA=; b=c/bIifV+jQ+/9XsgBQNiscbH7TwKhcQ/nKvDcBE/UzhcVGXFskEBa11lFyMsd+lI0P mdS4Wx3LlqzpBhqwkNDA== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOX2fDKnekUQVKPn9EujZhrJOXWHg==" Original-Received: from nimes.localnet by smtp.strato.de (RZmta 49.6.6 AUTH) with ESMTPSA id x129eaz76FkRZHV (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Sun, 6 Aug 2023 17:46:27 +0200 (CEST) In-Reply-To: <83h6pcp5rb.fsf@gnu.org> Received-SPF: none client-ip=81.169.146.164; envelope-from=bruno@clisp.org; helo=mo4-p01-ob.smtp.rzone.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308376 Archived-At: Eli Zaretskii wrote: > > Will you typically want to > > - review all format strings in Emacs, to see whether they are affected? > > - add some note to Emacs-internal coding guidelines, e.g. to the effect > > that %b should not be used? > > - review the mingw-specific *printf override, to see whether it > > needs a workaround (in case b) or an extension (in case c)? > > - or do nothing at all? > > Some mix of the above, depending on the case. But only for the MinGW > build. OK. How do you reliably get notified about the relevant changes? If you look at gnulib/ChangeLog and search for "mingw" or "Windows" you will spot some of the relevant changes. For more reliability, I would save the generated config.cache from a mingw build somewhere, and compare the config.cache of newer builds with the saved one. If you see an added gl_cv_* variable or an existing one whose value has changed, you can raise your eyebrows. So, it makes sense to override only the mimimum of gl_cv_* variables. However, this approach would still have its potential gaps: In case > > (b) because a bug has been discovered on mingw Gnulib might stuff the new configure test into an existing AC_RUN_IFELSE invocation and thus reuse an existing gl_cv_* variable. (Not for *printf, but for other modules.) Say, gl_cv_foobar_works meant the absence of bugs P and Q, and now it means the absence of bugs P, Q, and R. When the override gl_cv_foobar_works=yes was added, it meant "our nt code has workarounds for P and Q". Thus, you won't be alerted that you need to add a workaround for R or remove the override gl_cv_foobar_works=yes. If you were to build the corresponding gnulib tests as part of the Emacs build (gnulib-tool option '--with-tests'), then we would have added a unit test against bug R, and this test would fail, thus alerting you that you need to do something. Note: Since the gnulib-tool invocation includes many '--avoid' options, some test failures are to be expected, until these tests are '--avoid'ed as well. Bruno