From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Wolfgang Jenkner Newsgroups: gmane.emacs.devel Subject: Re: comint fix for shell colors Date: Fri, 18 Nov 2016 16:06:28 +0100 Message-ID: <582f18f4.iBWOd+O4h9885qPS%wjenkner@inode.at> References: <83twb5cd8t.fsf@gnu.org> <582f0f65.En4KsDnZnxPG7ZLy%wjenkner@inode.at> <83k2c0df63.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1479481684 4877 195.159.176.226 (18 Nov 2016 15:08:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Nov 2016 15:08:04 +0000 (UTC) User-Agent: Heirloom mailx 12.4 7/29/08 Cc: erik@selberg.org, emacs-devel@gnu.org To: eliz@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 18 16:08:00 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7klh-0000SW-Mw for ged-emacs-devel@m.gmane.org; Fri, 18 Nov 2016 16:07:57 +0100 Original-Received: from localhost ([::1]:37186 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7klk-0001bO-T1 for ged-emacs-devel@m.gmane.org; Fri, 18 Nov 2016 10:08:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7kkT-0001Wk-DW for emacs-devel@gnu.org; Fri, 18 Nov 2016 10:06:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7kkO-0007gp-4k for emacs-devel@gnu.org; Fri, 18 Nov 2016 10:06:41 -0500 Original-Received: from vie01a-dmta-at50-3.mx.upcmail.net ([62.179.121.138]:36760) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c7kkN-0007dr-SM for emacs-devel@gnu.org; Fri, 18 Nov 2016 10:06:36 -0500 Original-Received: from [172.31.216.41] (helo=vie01a-pemc-psmtp-at50) by vie01a-dmta-at50.mx.upcmail.net with esmtp (Exim 4.87) (envelope-from ) id 1c7kkJ-0005cU-He for emacs-devel@gnu.org; Fri, 18 Nov 2016 16:06:31 +0100 Original-Received: from iznogoud.viz ([91.119.229.141]) by vie01a-pemc-psmtp-at50 with SMTP @ mailcloud.upcmail.net id 9T6V1u00J33hQvv0BT6VoC; Fri, 18 Nov 2016 16:06:31 +0100 X-SourceIP: 91.119.229.141 X-CNFS-Analysis: v=2.2 cv=FpZHxCjq c=1 sm=2 tr=0 a=8Bn41pes2QP458Z0uIagyA==:117 a=8Bn41pes2QP458Z0uIagyA==:17 a=kj9zAlcOel0A:10 a=L24OOQBejmoA:10 a=mDV3o1hIAAAA:8 a=6ZG8JaRc29nQAPpnOsAA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 Original-Received: from wolfgang (uid 1002) (envelope-from wjenkner@inode.at) id 8a015 by iznogoud.viz (DragonFly Mail Agent v0.11); Fri, 18 Nov 2016 16:06:29 +0100 In-Reply-To: <83k2c0df63.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 62.179.121.138 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209479 Archived-At: Eli Zaretskii wrote: > > Date: Fri, 18 Nov 2016 15:25:41 +0100 > > From: Wolfgang Jenkner > > Cc: emacs-devel@gnu.org > > > > In emacs-25 and master comint-highlight-prompt is prepended to > > ansi-color faces used for highlighting prompts. The user has just > > to customize the comint-highlight-prompt face so that it doesn't > > inherit from minibuffer-prompt and it won't clobber anything. See > > > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20084 > > > > commit 792d44b3c31d2a682607ab8b79ae7d26b7402f41 > [...] > Indeed, I think this change should be described in NEWS. Could you > provide a patch for that, please? Please note that there's nothing new here, it was just a bug fix. The very first message in the bug report mentioned above states In Emacs 24.3, comint-highlight-prompt allows ANSI colors to show through if it does not specify any colors itself. In Emacs 24.4, it does not, even ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ if comint-highlight-prompt is the "empty face". Wolfgang