From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Wolfgang Jenkner Newsgroups: gmane.emacs.devel Subject: Re: comint fix for shell colors Date: Fri, 18 Nov 2016 15:25:41 +0100 Message-ID: <582f0f65.En4KsDnZnxPG7ZLy%wjenkner@inode.at> References: <83twb5cd8t.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1479479238 5131 195.159.176.226 (18 Nov 2016 14:27:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Nov 2016 14:27:18 +0000 (UTC) User-Agent: Heirloom mailx 12.4 7/29/08 Cc: emacs-devel@gnu.org To: erik@selberg.org, eliz@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 18 15:27:09 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7k8B-0008Ey-Uu for ged-emacs-devel@m.gmane.org; Fri, 18 Nov 2016 15:27:08 +0100 Original-Received: from localhost ([::1]:36956 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7k8F-0008Fc-22 for ged-emacs-devel@m.gmane.org; Fri, 18 Nov 2016 09:27:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7k70-0008BS-Gn for emacs-devel@gnu.org; Fri, 18 Nov 2016 09:25:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7k6w-0000dR-QC for emacs-devel@gnu.org; Fri, 18 Nov 2016 09:25:54 -0500 Original-Received: from vie01a-dmta-at52-1.mx.upcmail.net ([62.179.121.142]:32122) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c7k6w-0000XD-Iy for emacs-devel@gnu.org; Fri, 18 Nov 2016 09:25:50 -0500 Original-Received: from [172.31.216.41] (helo=vie01a-pemc-psmtp-at50) by vie01a-dmta-at52.mx.upcmail.net with esmtp (Exim 4.87) (envelope-from ) id 1c7k6q-0003p8-8Z for emacs-devel@gnu.org; Fri, 18 Nov 2016 15:25:44 +0100 Original-Received: from iznogoud.viz ([91.119.229.141]) by vie01a-pemc-psmtp-at50 with SMTP @ mailcloud.upcmail.net id 9SRh1u01733hQvv0BSRiyB; Fri, 18 Nov 2016 15:25:44 +0100 X-SourceIP: 91.119.229.141 X-CNFS-Analysis: v=2.2 cv=FpZHxCjq c=1 sm=2 tr=0 a=8Bn41pes2QP458Z0uIagyA==:117 a=8Bn41pes2QP458Z0uIagyA==:17 a=kj9zAlcOel0A:10 a=L24OOQBejmoA:10 a=mDV3o1hIAAAA:8 a=y4CinErdAAAA:8 a=sfoEUHvcZ91NPUg4cCIA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 a=FWzOGNgMwjTQ7reSSeIx:22 Original-Received: from wolfgang (uid 1002) (envelope-from wjenkner@inode.at) id 8a015 by iznogoud.viz (DragonFly Mail Agent v0.11); Fri, 18 Nov 2016 15:25:41 +0100 In-Reply-To: <83twb5cd8t.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 62.179.121.142 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209477 Archived-At: Eli Zaretskii wrote: > > From: Erik Selberg > > Date: Mon, 14 Nov 2016 23:14:25 -0800 > > > > I've been trying to use shell (vs term / mult-term) with bash / zsh and my color prompts. In comint, > > comint-highlight-prompt clobbers the colors. I made the following patch against 24.5 but I see comint has > > been updated in 25. What's the right process for adding this for 25? This is solved for me locally, but seems > > something that could be added for all. > > Please rebase the patch on the current master branch and resubmit. In emacs-25 and master comint-highlight-prompt is prepended to ansi-color faces used for highlighting prompts. The user has just to customize the comint-highlight-prompt face so that it doesn't inherit from minibuffer-prompt and it won't clobber anything. See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20084 commit 792d44b3c31d2a682607ab8b79ae7d26b7402f41 So I think there's nothing to do here execept perhaps for documenting something. Wolfgang