From: Wolfgang Jenkner <wjenkner@inode.at>
To: erik@selberg.org, eliz@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: comint fix for shell colors
Date: Fri, 18 Nov 2016 15:25:41 +0100 [thread overview]
Message-ID: <582f0f65.En4KsDnZnxPG7ZLy%wjenkner@inode.at> (raw)
In-Reply-To: <83twb5cd8t.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Erik Selberg <erik@selberg.org>
> > Date: Mon, 14 Nov 2016 23:14:25 -0800
> >
> > I've been trying to use shell (vs term / mult-term) with bash / zsh and my color prompts. In comint,
> > comint-highlight-prompt clobbers the colors. I made the following patch against 24.5 but I see comint has
> > been updated in 25. What's the right process for adding this for 25? This is solved for me locally, but seems
> > something that could be added for all.
>
> Please rebase the patch on the current master branch and resubmit.
In emacs-25 and master comint-highlight-prompt is prepended to
ansi-color faces used for highlighting prompts. The user has just
to customize the comint-highlight-prompt face so that it doesn't
inherit from minibuffer-prompt and it won't clobber anything. See
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20084
commit 792d44b3c31d2a682607ab8b79ae7d26b7402f41
So I think there's nothing to do here execept perhaps for documenting
something.
Wolfgang
next prev parent reply other threads:[~2016-11-18 14:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 7:14 comint fix for shell colors Erik Selberg
2016-11-18 10:07 ` Eli Zaretskii
2016-11-18 14:25 ` Wolfgang Jenkner [this message]
2016-11-18 14:40 ` Eli Zaretskii
2016-11-18 15:06 ` Wolfgang Jenkner
2016-11-18 15:34 ` Eli Zaretskii
2016-11-18 15:40 ` Erik Selberg
2016-11-18 15:49 ` Wolfgang Jenkner
2016-11-18 15:53 ` Erik Selberg
2016-11-18 19:24 ` Erik Selberg
2016-11-18 19:50 ` Eli Zaretskii
2016-11-18 22:43 ` Erik Selberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582f0f65.En4KsDnZnxPG7ZLy%wjenkner@inode.at \
--to=wjenkner@inode.at \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=erik@selberg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).