From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, john@yates-sheets.org
Subject: Re: Emphasizing the top of the frame
Date: Wed, 26 Oct 2016 19:56:07 +0200 [thread overview]
Message-ID: <5810EE37.70703@gmx.at> (raw)
In-Reply-To: <834m3zupgm.fsf@gnu.org>
>> But for that it (1) has to "walk the window tree as well" and (2) know
>> where to draw the minibuffer window.
>
> No, it doesn't. The window glyph matrices on TTY frames are actually
> portions of the frame glyph matrix, so whenever a window's glyphs are
> updated by xdisp.c, the corresponding glyphs of the frame are
> automagically updated as well.
Looks like changing the minibuffer position is harder for TTY frames.
>> > There are at least two functions in the display engine that walk the
>> > window tree,
>>
>> Which ones are that?
>
> redisplay_windows and hscroll_window_tree. I now see that so do
> mark_window_display_accurate, redisplay_mode_lines,
> update_cursor_in_window_tree, and expose_window_tree.
As a matter of fact, there are a few more in window.c - foreach_window,
mark_window_cursors_off, window_set_before_size_change_sizes,
window_size_changed and get_leaf_windows. So I suppose that John should
try hard to _not_ change the relative order of the root and minibuffer
window and hope that interchanging the coordinates (something he has to
do anyway) will suffice.
>> The window tree proper is the tree rooted at the root window. The root
>> window and the minibuffer window of a "normal" frame do not form a tree
>> - they have no common ancestor.
>
> Maybe I'm missing something, but there's this fragment in make_frame:
>
> root_window = make_window ();
> rw = XWINDOW (root_window);
> if (mini_p)
> {
> mini_window = make_window ();
> mw = XWINDOW (mini_window);
> wset_next (rw, mini_window);
> wset_prev (mw, root_window);
> mw->mini = 1;
> wset_frame (mw, frame);
> fset_minibuffer_window (f, mini_window);
> store_frame_param (f, Qminibuffer, Qt);
> }
>
> This seems to arrange for the minibuffer window to be the "next" of
> the root window, no?
Yes. The root of the next tree, as it were. Obviously, this next field
is convenient for walking the structure formed by the root tree and the
minibuffer window as your examples from the display engine show.
martin
next prev parent reply other threads:[~2016-10-26 17:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 17:53 Emphasizing the top of the frame John Yates
2016-10-25 18:04 ` Clément Pit--Claudel
2016-10-25 18:06 ` Drew Adams
2016-10-25 18:27 ` Eli Zaretskii
2016-10-25 18:40 ` Eli Zaretskii
2016-10-26 8:10 ` martin rudalics
2016-10-26 12:00 ` Eli Zaretskii
2016-10-26 12:31 ` martin rudalics
2016-10-26 13:13 ` Eli Zaretskii
2016-10-26 14:23 ` martin rudalics
2016-10-26 14:58 ` Eli Zaretskii
2016-10-26 17:56 ` martin rudalics [this message]
2016-10-26 18:40 ` Eli Zaretskii
2016-10-26 18:51 ` Eli Zaretskii
2016-10-26 19:26 ` Paul Eggert
2016-10-26 20:18 ` Stefan Monnier
2016-10-27 17:35 ` martin rudalics
2022-04-08 1:48 ` John Yates
2022-04-08 15:11 ` martin rudalics
2022-04-09 14:47 ` John Yates
2022-04-10 8:42 ` martin rudalics
2022-04-10 14:50 ` John Yates
2022-04-11 7:13 ` martin rudalics
2022-04-10 16:23 ` [External] : " Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5810EE37.70703@gmx.at \
--to=rudalics@gmx.at \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=john@yates-sheets.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).