[PATCH] Elpa's GNUmakefile: process_archive

[Serghei Iakovlev <egrep@protonmail.ch>]

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

Hello,

I've noticed a bug in Elpa's GNUmakefile file.  `process_archive'
target contains incorrect code to exclude files from a package.
There are positional options (`--exclude-vcs' and `-X') which used
in an obviously erroneous way.

Let's me show you the problem:

  % tar -chf bnf-mode.tar bnf-mode \
    --exclude-vcs -X bnf-mode/.elpaignore

  tar: The following options were used after any non-optional
  arguments in archive create or update mode.  These options are
  positional and affect only arguments that follow them.  Please,
  rearrange them properly.
  tar: --exclude-vcs has no effect
  tar: --exclude-from ‘bnf-mode/.elpaignore’ has no effect
  tar: Exiting with failure status due to previous errors

I've attached the patch that fixes this issue.  For more see [1].

[1]:
https://www.gnu.org/software/tar/manual/html_node/Position_002dSensitive-Options.html

--
Serghei


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: GNUmakefile.patch --]
[-- Type: text/x-patch; name="GNUmakefile.patch", Size: 420 bytes --]

diff --git a/GNUmakefile b/GNUmakefile
index 2560ab95b..6fff547db 100644
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -64,7 +64,7 @@ process-archive:
 	      fi;						\
 	      if [ -d $$pt ]; then				\
 		  echo "Creating tarball $${pt}.tar" &&		\
-		  tar -chf $${pt}.tar $$pt --exclude-vcs -X "$$ignore";	\
+		  tar -chf $${pt}.tar --exclude-vcs -X "$$ignore" $$pt ;	\
 		  rm -rf $${pt}; 				\
 	      fi;						\
 	  done