unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: ingo.lohmar@posteo.net, emacs-devel@gnu.org
Subject: Re: set-frame-size should respect line-spacing!?
Date: Sun, 13 Oct 2019 19:06:52 +0200	[thread overview]
Message-ID: <57de2a38-3b9e-4d44-c1a5-a2d1bd988292@gmx.at> (raw)
In-Reply-To: <83ftjwlr2q.fsf@gnu.org>

 >> That of how it should handle line spacing and face remapping when
 >> resizing a window.  For example, how should we relate the desired
 >> height of a window to the value of 'window-min-height' when these are
 >> in effect?
 >
 > I think the only case where the issues raised by bug#14825 should
 > matter is when we decide whether a window is too small.  E.g., what
 > bad things will happen if we interpret window-min-height in terms of
 > the default face's font set for the buffer shown (or to be shown) in
 > the window?

Such an interpretation would cut both ways.  Think of people that use
'line-spacing' for ages or have remapped the default face font to
something higher.  They would be surprised that C-x 2 all of a sudden
complains that their window is "too small for splitting".

Also note that often the buffer to be shown in the new window, for
example via 'pop-to-buffer', is unknown to 'split-window'.

I'm not against a fix for Bug#14825.  But doing it in a clean and
consistent way will be pretty hard.  Look at how often 'split-window'
calls 'window-sizable-p'.  All these calls would have to be rewritten
in some way or the other.

martin



  reply	other threads:[~2019-10-13 17:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11 20:44 set-frame-size should respect line-spacing!? Ingo Lohmar
2019-10-12  7:00 ` Eli Zaretskii
2019-10-12  7:12   ` Ingo Lohmar
2019-10-12  7:48     ` Eli Zaretskii
2019-10-12  8:25       ` martin rudalics
2019-10-12  8:25     ` martin rudalics
2019-10-12  9:45       ` Eli Zaretskii
2019-10-12  9:56         ` Ingo Lohmar
2019-10-12 11:03         ` martin rudalics
2019-10-12 13:11           ` Eli Zaretskii
2019-10-13  8:16             ` martin rudalics
2019-10-13  9:10               ` Eli Zaretskii
2019-10-13 12:15                 ` martin rudalics
2019-10-13 12:18                   ` Eli Zaretskii
2019-10-13 12:51                     ` martin rudalics
2019-10-13 13:20                       ` Eli Zaretskii
2019-10-13 17:06                         ` martin rudalics [this message]
2019-10-14  8:06                           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57de2a38-3b9e-4d44-c1a5-a2d1bd988292@gmx.at \
    --to=rudalics@gmx.at \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=ingo.lohmar@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).