From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: Proposal: font lock for `describe-variable` Date: Wed, 28 Sep 2016 00:21:13 -0400 Message-ID: <57d030e9-1f2e-bc8e-f032-6ac345798c5f@gmail.com> References: <1474949378.32234.5.camel@gmail.com> <83shslbax3.fsf@gnu.org> <83ponpb5rv.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9raQWomvUhjEn8NaMvEfKBwVJJptXktK2" X-Trace: blaine.gmane.org 1475036526 12173 195.159.176.226 (28 Sep 2016 04:22:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Sep 2016 04:22:06 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Tianxiang Xiong , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 28 06:22:02 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bp6NL-0000ON-J5 for ged-emacs-devel@m.gmane.org; Wed, 28 Sep 2016 06:21:45 +0200 Original-Received: from localhost ([::1]:55907 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bp6NG-0007vd-Ou for ged-emacs-devel@m.gmane.org; Wed, 28 Sep 2016 00:21:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bp6NB-0007nr-8L for emacs-devel@gnu.org; Wed, 28 Sep 2016 00:21:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bp6N6-0006SJ-5w for emacs-devel@gnu.org; Wed, 28 Sep 2016 00:21:32 -0400 Original-Received: from mout.kundenserver.de ([217.72.192.73]:65047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bp6N5-0006S9-RX; Wed, 28 Sep 2016 00:21:28 -0400 Original-Received: from [18.189.53.55] ([18.189.53.55]) by mrelayeu.kundenserver.de (mreue102) with ESMTPSA (Nemesis) id 0MUnjI-1bRzSg19xM-00YBZx; Wed, 28 Sep 2016 06:21:22 +0200 In-Reply-To: X-Provags-ID: V03:K0:+/nRHRtvwrQ+h8JlHcQYqoTJHQmPvBcmMMkB9yHRPebBB6f1Ljy nsqBP/JaLWwGP940t0ZkUOPQYVRRfagRy3o43W7nt64O/nGIx+GpI22rUMVqohQVK6tO3MR 2KJn4jLA1e64hYTTroWwEQl4Rgcf1iG6DhEzyFFMyyjxa/M8YnlecRmaAwz8TIftlL0GaVu B8oaQrsESZA7p74m/ByXA== X-UI-Out-Filterresults: notjunk:1;V01:K0:X68fhofU9o0=:8AiOy9aGfYMj4itfCMCIlP x/6uV4DVtnIglfZBiX00UvkyuAmx15rQ1EzDGFz1ib70S0vi6LLJjFyQfeeKT1BnpFoWI2OW0 UODhkTmvmjGxauZ64sj5kfv7gtqXxFmyKJIcdMIqDRjpeVnWVFDH61bR88WjqxAiv2v/lw8Dg hfo2zmHypD0tWTI9ffwgunX7HhvIosr5Dh7H3i2FwHZb61jX37mieLk3s6lmzRWQt06WS590n XLGgwZCaMxccXevj3HRQL7oldsjPw2fzMSGigE61OZfoIMvqK6hyp4e1MvO1wfOjoiru2vSmA q5thf9NZEy7W/eaBCYhGFJTCC648OsVesIkUjbSsvVlF2GZ7dkPab2rCP/CzNHa15OOszhI98 K1sdlhlEHuEJZGpBVgjhlB7I7JiykOwfp3w9HbQDY1anaRs/JMcGBSQ+mzPSDpQqgpbqFgp24 ibXhjAoYHlkMG5qTCVfOQlz7N8GlJLgmf5mVFQSdbu15vriA8QHV4OJLZFfe32Ow4dxAvakcu gM0Pa6LZ+aozt6wGqidkl5QjvgwZwRTQeLCQKl1XfFtMsCuYxb10e1YQsjFjRCX02ucCC9VJf zBKIKRK/YUM0pr9F6yqxhVLn2zAumngaGD1SYqt/rz7dOXkhHwCvI5IKWTU1YO1jGxWEdCo7z Vul1XS5k/cbo6zGYrqnMyjJhkQ/5nw3r+5GqmT2U1qVBRxZFf1mUM2JAlexXXjrvfbZI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.72.192.73 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207848 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9raQWomvUhjEn8NaMvEfKBwVJJptXktK2 Content-Type: multipart/mixed; boundary="pbdJsW2dDAKE5266IWwA2bkMnj652ppGi"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: Tianxiang Xiong , Eli Zaretskii Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca Message-ID: <57d030e9-1f2e-bc8e-f032-6ac345798c5f@gmail.com> Subject: Re: Proposal: font lock for `describe-variable` References: <1474949378.32234.5.camel@gmail.com> <83shslbax3.fsf@gnu.org> <83ponpb5rv.fsf@gnu.org> In-Reply-To: --pbdJsW2dDAKE5266IWwA2bkMnj652ppGi Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable I think Eli is pointing out that in every place where you made a modifica= tion to the code, you also changed the whitespace. For example, you unta= bified all three lines of the following chunk. - (setq output - (format "This variable was introduced, or its default value was c= hanged, in\nversion %s of Emacs.\n" - custom-version)) + (setq output + (format "This variable was introduced, or its default valu= e was changed, in version %s of Emacs.\n" + custom-version)) Cl=E9ment. On 2016-09-27 23:45, Tianxiang Xiong wrote: > @Eli I don't know what you mean, then. The diffs in the 0002 version ar= e definitely not due to whitespace changes; I explicitly removed the whit= espace-only changes from 0001. >=20 > There /is/ a good amount of refactoring, simply because the previous co= de was very hard to follow. The new code is ~40 lines shorter and, if I d= o say so myself, much clearer. >=20 > I've attached the 0002 version again in case there's something wrong wi= th the previous one. >=20 > 2016-09-27 10:40 GMT-07:00 Eli Zaretskii >: >=20 > > From: Tianxiang Xiong > > > Date: Tue, 27 Sep 2016 09:30:18 -0700 > > Cc: emacs-devel@gnu.org , monnier@iro= =2Eumontreal.ca , > > Cl=E9ment Pit--Claudel > > > > > Even the 0002 version? >=20 > Yes. >=20 >=20 --pbdJsW2dDAKE5266IWwA2bkMnj652ppGi-- --9raQWomvUhjEn8NaMvEfKBwVJJptXktK2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX60U+AAoJEPqg+cTm90wjOU0P/2zyTfvPGyCn+CxROWhRyaIo 6vDwP25dyKEhJ7ZwAcAXF1j4jQwUmd1whF3qML0V93eolpF3LUoUkXckoVYeVAHK bw8I59JM91KEInZm3eTaak6u3sHM7RCHnn8nWXiZP920guq6ca8EPvcnjPEucSzZ KgS2+rjTaDiz5jS3eUPiXEF+/DLOlkZmByW4jJ8J9wKrcdmM8ioqte73DnmltsHl 1UIvCbXKUUnUw6XJPB8LavmcZrqhqAP+423nQk89FpS0HK0ptH6yINEuId3/lMqa 5jBTUNdYU4nVkjKMFd2qe5YFiasfMMZqr26H2aVRb887fF6GI9xX26CM0BgWUsVP y9JiAkDWb/oCXxUE/jNnf5Jr5+y6CudPnISSrQ5fGeZoK3RMCGEOX7NH471qDHh5 XG0vmtjF3unRnEvoDWp7TNdakzCYT0TwDmhiSSBtSGcTG4/Ub9Owrxhj5k4QOeVR pM5UB9fX/GuceF1/feSUD+raG1b6ACIxoW/xarywF1LsNKIVfCo4SY/6h2DpPoDR ADmqVjsrCGVeuPUnoa/qOOwR7SE6R2elQ+09b6CBtiu6ZGL+XxGWA/65wrCApGXu AkNT5npXTuusq1IQEYCVhEvDFvr0UnbUyT5bW91pBNCZJPsuy7QOK8hBOvUvns4C W2Tem8+guBAdUQhbToHt =9NTH -----END PGP SIGNATURE----- --9raQWomvUhjEn8NaMvEfKBwVJJptXktK2--