From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: About the 'minibuffer' frame parameter Date: Tue, 09 Aug 2016 18:07:58 +0200 Message-ID: <57A9FFDE.10106@gmx.at> References: <579E3F9E.8020200@gmx.at> <83h9azl4s1.fsf@gnu.org> <57A4C0DE.3060506@gmx.at> <837fbvkofs.fsf@gnu.org> <57A5AF03.30807@gmx.at> <8360rck7kd.fsf@gnu.org> <57A84256.8030706@gmx.at> <83popji89w.fsf@gnu.org> <57A9940B.6030005@gmx.at> <8337mehu5u.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1470763746 15862 195.159.176.226 (9 Aug 2016 17:29:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 9 Aug 2016 17:29:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 09 19:29:02 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bXApp-00040c-RC for ged-emacs-devel@m.gmane.org; Tue, 09 Aug 2016 19:29:01 +0200 Original-Received: from localhost ([::1]:36989 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXApm-0001VX-Hh for ged-emacs-devel@m.gmane.org; Tue, 09 Aug 2016 13:28:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX9Zd-0002MC-Gd for emacs-devel@gnu.org; Tue, 09 Aug 2016 12:08:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bX9ZZ-0006Tj-8O for emacs-devel@gnu.org; Tue, 09 Aug 2016 12:08:12 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:60346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX9ZY-0006Te-TS; Tue, 09 Aug 2016 12:08:09 -0400 Original-Received: from [192.168.1.100] ([212.95.7.105]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MZOan-1bnIJW1Qar-00LGlA; Tue, 09 Aug 2016 18:08:07 +0200 In-Reply-To: <8337mehu5u.fsf@gnu.org> X-Provags-ID: V03:K0:nAhECTqdLukqvPTJrS0qgtV6LR6BFQQyGc4D+8XXs6f4sXuFi0Z golyUZbAALnAr64BD7/QrIK5TmcGY8Dc09F+DELjRL5wxhZDzSINuYlSUUDr/KEQ0b7QIJ0 Q+pw+vQ7Y9R7oL3p5UvDiVc8J35L469LrLwk7vasXbttiQuEiIF5zmBf7n7n6DY3GoZAlhU HVfttXN5BP0kxwcfMJzfQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:FPEaZDTiNZA=:ScbDZSEpNRLrdt3pANSgor 0xnhoDs2mWoqYjlyfnoXbMZnzCJI1E5ZZFpP3XBxr2y/77i2D4by/6HiqSmipb1cfXjgCIpmI cNCgNYNi/mbxYmJMosH63B7ed+GT872QSeqNGYJAGln8XTwNf/W3BfRpCFY0Jem4RkOPS06Ke l+q+/MRIdqJU+vdt7hJ+sanlmjQmRbmUke9LU+ErQqSj0Sc9RDDI/aegX26Xw2A2byjaYg40D lavoO9X83OFr/9riZw8p3tdJKZIvBz9NEtQfZ3/2Eh6NTQhHrJMuvzdCXhliyODFsm8Fp7JnE KYeWT5qEdMN4vGp43/U26WnAWbZVS5/HFLo2dbK4wWtrUyyZ4MXReYAi8Nxf45sHfh2FLDkxc tcKJq5Pcmj0Sm1SH9NbGKHeo+NsVSmGD8LMw2n0O1LSrol4b9S5SlTr/WHllVm9/ReNRsnjiE baUw9QY7Bah7F+hyAY6hvhxVlaCafEPpI/5G5et26lwwNebL73aL+TcIrS/EqOa0PMWe9qkbu RZ2Aqm7HT0TIuHDh7tAVW5Xt7hXotTTs+fTeAU+zkHw+oGrGdry5niMCVdqzDZTzQgQMBTm/h KIts4fHEgKJ5a2KkL6hgISxt5TeCWg5NbU4Pyghv4qiF6sXnDdazeDlU+tVzVLeVaRcqv9qVI 0UqYZ5eWeO3BteHCFspCYmTICnVFGEodupl8+T8gCzpANtqcFAVrt1NXLmGRoFjFvMhtmPZbM yyapYPqTSkQSxlbafdPHtdb9o5AGoGawk3xBQvgwbCAgXIBek4Mg/QCj/xHfK6wkyTW8xvil X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206512 Archived-At: >> (1) Make sure that store_frame_param doesn't store invalid parameter >> values. >> >> (2) Never store a minibuffer window as frame parameter. >> >> (3) Have =E2=80=98frame-parameter=E2=80=99 return the 'minibuffer' pa= rameter as stored >> internally. If no stored value is available, return t. >> >> (4) Wait for regression reports. >> >> (5) Fix the documentation. >> >> (6) Fix/remove related comments. > > I'm okay with that, but I'm surprised by (2): won't storing the > minibuffer window there allow us to report the correct value in (3)? > What am I missing? If we did that we would invert the values returned by =E2=80=98frame-para= meter=E2=80=99 for the "normal" frame and minibuffer-less frame cases. Currently, we return the minibuffer window for a normal frame and nil for a minibuffer-less frame. You would return the minibuffer window for a minibuffer-less frame and t for a normal frame. Correct? This would have the benefit that after (set-frame-parameter minibuffer-less-frame 'minibuffer some-minibuffer= -window) the value returned by =E2=80=98frame-parameter=E2=80=99 would be consiste= nt with the requested value. However, most minibuffer-less frames are created via (make-frame '((minibuffer . nil))) and whatever we do here we would introduce another inconsistency: Either the stored value is the minibuffer window chosen by Emacs and the value returned by =E2=80=98frame-parameter=E2=80=99 would not be the value from= the PARAMETERS argument of =E2=80=98make-frame=E2=80=99. Or we would sometimes return n= il and sometimes a window as value of the 'minibuffer' frame parameter of a minibuffer-less frame. Given the fact that changing the frame parameter of a minibuffer-less frame is a pretty rare operation, I would prefer the solution sketched in (2). WDYT? martin