unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Cédric Chépied" <cedric.chepied@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: ampc back on elpa?
Date: Fri, 17 Jun 2016 18:43:23 +0200	[thread overview]
Message-ID: <576428ac.aa29c20a.20e25.fffff88b@mx.google.com> (raw)
In-Reply-To: <jwvziqmiocd.fsf-monnier+gmane.emacs.devel@gnu.org>

On Wed, 15 Jun 2016 15:35:43 +0200,
Stefan Monnier wrote:
> Looks good.  I was about to install the change into elpa.git but I can't
> find your name in the list of people who assigned copyright.
> Have you signed the copyright paperwork?

Signed but not sent. I'm too lazy, post office is so far...
I'm sending it tomorrow.

> In the mean time, here's a comment about:
> 
> +(defun ampc-start-search ()
> +  "Ask mpd to search for songs matching keywords"
> +  (interactive)
> +  (cl-assert (ampc-in-ampc-p))
> +  (let ((search (read-string "Keywords: ")))
> 
> This should look more like
> 
>     (defun ampc-start-search (search)
>       "Ask mpd to search for songs matching keywords."
>       (interactive "sKeywords: ")
>       (cl-assert (ampc-in-ampc-p))

I'm sending a new patch soon for this. 

Thanks for the help.
-- 
Cédric Chépied
<cedric.chepied@gmail.com>



  reply	other threads:[~2016-06-17 16:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-14 16:31 ampc back on elpa? Cédric Chépied
2016-05-14 14:48 ` Stefan Monnier
2016-05-25  6:07   ` Cédric Chépied
2016-05-25  8:32     ` Stefan Monnier
2016-06-10 13:25       ` Cédric Chépied
2016-06-10 15:52         ` Stefan Monnier
2016-06-13  7:23           ` Cédric Chépied
2016-06-13 12:45         ` Stefan Monnier
2016-06-15  9:53           ` Cédric Chépied
2016-06-15 13:35             ` Stefan Monnier
2016-06-17 16:43               ` Cédric Chépied [this message]
2016-06-17 22:28                 ` Stefan Monnier
2016-06-20 11:47                   ` Cédric Chépied
2016-07-01 11:25                     ` Cédric Chépied
2016-07-27 13:58                       ` Cédric Chépied
2016-07-27 14:40                         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576428ac.aa29c20a.20e25.fffff88b@mx.google.com \
    --to=cedric.chepied@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).