unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master dce99f2: Fix ifdef-vs-if typo with RANDR13_LIBRARY
       [not found] ` <20160615054045.8F25E220116@vcs.savannah.gnu.org>
@ 2016-06-16  0:14   ` Glenn Morris
  2016-06-16  0:23     ` Paul Eggert
  0 siblings, 1 reply; 3+ messages in thread
From: Glenn Morris @ 2016-06-16  0:14 UTC (permalink / raw)
  To: emacs-devel; +Cc: Paul Eggert

Paul Eggert wrote:

> -#ifdef RANDR13_LIBRARY
> +#if RANDR13_LIBRARY

Since this change is obviously correct, I don't understand why it wasn't
made on the release branch.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: master dce99f2: Fix ifdef-vs-if typo with RANDR13_LIBRARY
  2016-06-16  0:14   ` master dce99f2: Fix ifdef-vs-if typo with RANDR13_LIBRARY Glenn Morris
@ 2016-06-16  0:23     ` Paul Eggert
  2016-06-16  0:40       ` John Wiegley
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Eggert @ 2016-06-16  0:23 UTC (permalink / raw)
  To: Glenn Morris, emacs-devel

On 06/15/2016 05:14 PM, Glenn Morris wrote:
> Since this change is obviously correct, I don't understand why it wasn't
> made on the release branch.

That would make sense to me too. However, John thought it better to put 
it in the master branch. See:

http://lists.gnu.org/archive/html/emacs-devel/2016-06/msg00207.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: master dce99f2: Fix ifdef-vs-if typo with RANDR13_LIBRARY
  2016-06-16  0:23     ` Paul Eggert
@ 2016-06-16  0:40       ` John Wiegley
  0 siblings, 0 replies; 3+ messages in thread
From: John Wiegley @ 2016-06-16  0:40 UTC (permalink / raw)
  To: Paul Eggert; +Cc: Glenn Morris, emacs-devel

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

>>>>> Paul Eggert <eggert@cs.ucla.edu> writes:

> That would make sense to me too. However, John thought it better to put it
> in the master branch. See:

> http://lists.gnu.org/archive/html/emacs-devel/2016-06/msg00207.html

I didn't look at the actual patch before saying that, only the description
that it doesn't affect most X11 installations. We want to avoid unnecessary
changes at this point, however small.

That said, this does look truly harmless, so I'd be fine with cherry picking
it to emacs-25.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 629 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-16  0:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20160615054045.13780.99017@vcs.savannah.gnu.org>
     [not found] ` <20160615054045.8F25E220116@vcs.savannah.gnu.org>
2016-06-16  0:14   ` master dce99f2: Fix ifdef-vs-if typo with RANDR13_LIBRARY Glenn Morris
2016-06-16  0:23     ` Paul Eggert
2016-06-16  0:40       ` John Wiegley

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).