From: "Clément Pit--Claudel" <clement.pit@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Generalizing make-composed-keymap
Date: Wed, 15 Jun 2016 11:34:54 -0400 [thread overview]
Message-ID: <5761759E.2080807@gmail.com> (raw)
In-Reply-To: <jwvshweh40e.fsf-monnier+gmane.emacs.devel@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 739 bytes --]
On 2016-06-15 11:23, Stefan Monnier wrote:
> BTW, currently make-composed-keymap takes a list of maps as argument,
> but I'm beginning to think it would make sense to also accept (KEY
> . CMD) elements in that list, so that we can just say
>
> (make-composed-keymap
> '((" " my-space-replacement)
> ("?" nil)) ; Just hide the old ? binding.
> my-parent-map)
>
> instead of
>
> (let ((map (make-sparse-keymap)))
> (set-keymap-parent map my-parent-map)
> (define-key map " " 'my-space-replacement)
> (define-key map "?" nil)
> map)
>
> WDYT?
What about adding a `parent' option to make-sparse-keymap instead? That could help with discoverability.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2016-06-15 15:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160614214332.2901.16184@vcs.savannah.gnu.org>
[not found] ` <20160614214332.C030F220116@vcs.savannah.gnu.org>
2016-06-15 2:12 ` [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695) Stefan Monnier
2016-06-15 9:42 ` Stephen Berman
2016-06-15 13:16 ` Stefan Monnier
2016-06-15 15:09 ` Stephen Berman
2016-06-15 15:19 ` Eli Zaretskii
2016-06-15 17:31 ` John Wiegley
2016-06-15 18:10 ` Stephen Berman
2016-06-16 3:04 ` Noam Postavsky
2016-06-16 9:11 ` Stephen Berman
2016-06-15 15:23 ` Generalizing make-composed-keymap (was: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695).) Stefan Monnier
2016-06-15 15:34 ` Clément Pit--Claudel [this message]
2016-06-15 15:41 ` Generalizing make-composed-keymap Stefan Monnier
2016-06-15 15:37 ` [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695) Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5761759E.2080807@gmail.com \
--to=clement.pit@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).