unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Issue in src/xfns.c
@ 2016-06-14 18:02 Christian Lynbech
  2016-06-15  4:16 ` Ken Raeburn
  0 siblings, 1 reply; 4+ messages in thread
From: Christian Lynbech @ 2016-06-14 18:02 UTC (permalink / raw)
  To: emacs-devel


I am not entirely sure what the intention was, but I think there is a
small issue in xfns.c in relation to the RANDR13_LIBRARY macro.

It is used in two places, one where it uses #if and another that uses
#ifdef, the latter of which I think should have been a #if. At least it
failed to compile for me on a rather old linux system with a setup I
know onbly a little about. The define that introduces RANDR13_LIBRARY is
a boolean expression so RANDR13_LIBRARY is always defined.

As far as I can see this is still present in the git repository on the
master branch. An attempt of a patch is given below.


Index: xfns.c
===================================================================
--- xfns.c              (revision 7708)
+++ xfns.c           (working copy)
@@ -4286,7 +4286,7 @@
   n_monitors = resources->noutput;
   monitors = xzalloc (n_monitors * sizeof *monitors);
-#ifdef RANDR13_LIBRARY
+#if RANDR13_LIBRARY
   if (randr13_avail)
     pxid = XRRGetOutputPrimary (dpy, dpyinfo->root_window);
#endif


------------------------+-----------------------------------------------------
Christian Lynbech       | christian #\@ defun #\. dk
------------------------+-----------------------------------------------------
Hit the philistines three times over the head with the Elisp reference manual.
                                        - petonic@hal.com (Michael A. Petonic)



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-06-15  5:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-14 18:02 Issue in src/xfns.c Christian Lynbech
2016-06-15  4:16 ` Ken Raeburn
2016-06-15  4:56   ` John Wiegley
2016-06-15  5:41     ` Paul Eggert

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).