From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Spurious "file errors" when making master Date: Sat, 28 May 2016 03:54:25 -0700 Organization: UCLA Computer Science Department Message-ID: <574978E1.9010301@cs.ucla.edu> References: <5746A61F.3030406@gmx.at> <5746A78B.6050202@cs.ucla.edu> <5746B1B0.6070208@gmx.at> <83h9dk3l76.fsf@gnu.org> <574848EF.9080307@gmx.at> <834m9j1vpf.fsf@gnu.org> <57484CF3.6000709@gmx.at> <8337p31ucx.fsf@gnu.org> <574852C1.7010603@gmx.at> <83y46vziqp.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------050304070509070808090804" X-Trace: ger.gmane.org 1464432933 21534 80.91.229.3 (28 May 2016 10:55:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 28 May 2016 10:55:33 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii , martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 28 12:55:26 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b6btt-0001YD-G9 for ged-emacs-devel@m.gmane.org; Sat, 28 May 2016 12:55:25 +0200 Original-Received: from localhost ([::1]:52951 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6bts-0006aS-Jl for ged-emacs-devel@m.gmane.org; Sat, 28 May 2016 06:55:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6bt7-0006Yw-0Y for emacs-devel@gnu.org; Sat, 28 May 2016 06:54:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6bt4-0007bW-U3 for emacs-devel@gnu.org; Sat, 28 May 2016 06:54:35 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:58846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6bsz-0007Zs-Tt; Sat, 28 May 2016 06:54:30 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 984051613E4; Sat, 28 May 2016 03:54:27 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id RHJzfXa0oOYk; Sat, 28 May 2016 03:54:26 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 680F41613E6; Sat, 28 May 2016 03:54:26 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id OyEEcwHUkCZc; Sat, 28 May 2016 03:54:26 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 23D8B1613E4; Sat, 28 May 2016 03:54:26 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 In-Reply-To: <83y46vziqp.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204108 Archived-At: This is a multi-part message in MIME format. --------------050304070509070808090804 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Eli Zaretskii wrote: > I'm not sure I understand why we invoke Git in this case: the > source-directory is known and used by emacs-repository-get-version, so > why cannot it do the same it does for an in-tree build, i.e. access > the files in .git/ directly, just relative to source-directory? Yes, that's how it works for me. If I try the attached debugging patch, 'make' chatters as follows: Loading leim/leim-list.el (source)... emacs-repository--version-git-1 /home/eggert/src/gnu/emacs/static-checking/.git/HEAD /home/eggert/src/gnu/emacs/static-checking/.git emacs-repository--version-git-1 /home/eggert/src/gnu/emacs/static-checking/.git/refs/heads/master /home/eggert/src/gnu/emacs/static-checking/.git Finding pointers to doc strings... Finding pointers to doc strings...done which is what I'd expect: git does not get executed. Martin, can you investigate why git is executed in your case? --------------050304070509070808090804 Content-Type: text/x-diff; name="t.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="t.patch" diff --git a/lisp/version.el b/lisp/version.el index dc22887..ec04154 100644 --- a/lisp/version.el +++ b/lisp/version.el @@ -118,6 +118,7 @@ emacs-repository-version-git (defun emacs-repository--version-git-1 (file dir) "Internal subroutine of `emacs-repository-get-version'." + (message "emacs-repository--version-git-1 %s %s" file dir) (when (file-readable-p file) (with-temp-buffer (insert-file-contents file) --------------050304070509070808090804--