From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Adrian Robert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs.app dev]: ghost cursor problem is still there Date: Wed, 20 Aug 2008 08:27:04 -0400 Message-ID: <5742BBB5-9A2C-4E44-846D-AF4A46588DB2@gmail.com> References: <5f089c510807191428n349bdf55gebdff2e0ca668db7@mail.gmail.com> <7C93A2A7-54FD-43A9-BA1B-0B8502FFA5C6@gmail.com> <1AFEFF71-2AEA-4282-915E-B03050E98592@gmail.com> <8ED46157-6210-4767-A5AE-0DDE4C9DB1B3@gmail.com> <90AB958C-083A-4DA6-86B6-C63DB82776CE@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v926) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1219235332 21890 80.91.229.12 (20 Aug 2008 12:28:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 Aug 2008 12:28:52 +0000 (UTC) Cc: "emacs.app dev list" , Emacs-Devel devel To: David Reitter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 20 14:29:42 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KVmne-0004Di-LI for ged-emacs-devel@m.gmane.org; Wed, 20 Aug 2008 14:28:30 +0200 Original-Received: from localhost ([127.0.0.1]:60364 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KVmmh-0006KB-3G for ged-emacs-devel@m.gmane.org; Wed, 20 Aug 2008 08:27:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KVmmb-0006JV-Rf for emacs-devel@gnu.org; Wed, 20 Aug 2008 08:27:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KVmmb-0006Iu-0J for emacs-devel@gnu.org; Wed, 20 Aug 2008 08:27:25 -0400 Original-Received: from [199.232.76.173] (port=58309 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KVmma-0006Iq-UO for emacs-devel@gnu.org; Wed, 20 Aug 2008 08:27:24 -0400 Original-Received: from qw-out-1920.google.com ([74.125.92.149]:7646) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KVmma-0006Pq-MU for emacs-devel@gnu.org; Wed, 20 Aug 2008 08:27:24 -0400 Original-Received: by qw-out-1920.google.com with SMTP id 4so50050qwk.24 for ; Wed, 20 Aug 2008 05:27:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=I03chYULOPx2QWwLxYyKXQUNgjMXCQw/n812fUyJHVk=; b=OcHLy9HmiMjCk8j2v5ctVRXOaf+6YuQvrkv7vaSCzeppZvBQG7vhkdy3Y8IMnM/4oX vjhtwMhbo7X6Xdkh8Ed4PabKuvAOiwOzuY7MeXw5dTWanVytZJmZO2Pfk6A/UsewK3Is 3SFqIHg/r3AY0TEa7j/XKCavFCejygsC/ql34= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=CGuXNS1AxecM9Tw+9NDLMpkSMt6UBx+Q3YrRaNdxDJ/jwi0FU2v5ta2JbGZeH0KvTx SE98xn4I/MI/GUpRKud8Prd2ot1W9gPWo6Vg2R+PJSGNFsAG4tPjhdiV0UTzSwIGmBN1 V0cR0K6XG+bGXwtXbLiPuneJ5HLKNYPI8k0H4= Original-Received: by 10.214.10.18 with SMTP id 18mr21840qaj.27.1219235243302; Wed, 20 Aug 2008 05:27:23 -0700 (PDT) Original-Received: from ?10.0.1.200? ( [97.73.30.9]) by mx.google.com with ESMTPS id 9sm3137159yws.5.2008.08.20.05.27.13 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 20 Aug 2008 05:27:22 -0700 (PDT) In-Reply-To: <90AB958C-083A-4DA6-86B6-C63DB82776CE@gmail.com> X-Mailer: Apple Mail (2.926) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102721 Archived-At: On Aug 20, 2008, at 1:22 AM, David Reitter wrote: > Adrian et al, > > On 22 Jul 2008, at 09:41, David Reitter wrote: >> >> The main changes are that we check cursor_type instead of >> cursorType and draw the text glyph rather than the cursor when >> erasing anything (`hl' variable). There's a range of steps that we >> do to ensure that the cursor area is actually visible; I'm not sure >> if they are really needed, but the corresponding X code does it, too. >> There is a good bit of guess-work involved, but I'm sure that >> testing will take care of any problems. > > OK, in my latest build, things work a lot better and the original > blink-cursor-mode appears to work fine now. (I don't quite > understand which change made the event mechanisms work better.) This is great news. > To repeat, these changes address the following issues: > > - frame background rather than the right glyph in the white-out > phases during blinking > - `cursor-type' variable as in core Emacs, rather than NS specific > solution > - with it, support for things like (box . 2) > - box/hollow cursors too narrow OK, these were from before. > - standard blink-cursor-mode with all its bells and whistles > (whether one needs them or not) This is new, and good. > I would also take the blink rate stuff out of the preferences (a > patch to the nib) - it doesn't work with the generic blinking code > and I believe it's there for historic reasons (because the NS port > implemented blinking separately) rather than because it would be > very important to have for users (one could think of much more > important settings that could be there). This is a matter of opinion and at least I personally find blink and other cursor attributes I like to change easily and frequently. It should be an extremely simple matter to update the prefs controller code to set the core emacs blink rate, and I will do so once you've checked your changes in. The prefs window may be removed completely before 23.1 as it faces hostility from many quarters so I'd rather keep it fully functional until then. > The occasional ghost cursors seem to remain. I've been occasionally looking at this when I've had the chance. It has not been easy to track down. I get it (Leopard) in latest source and for a while back to around the merge, but not in rc2a. I think the best chance will be to try to find the first date/version when the problem appeared and then diff the source code (xdisp.c, dispnew.c, and xterm.c will probably tell the story). If anyone has information on this, please post it. > Any objections? I'm fine with this being committed. thanks, Adrian