From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: O_BINARY and emacs_open (was: Build failure for Emacs master) Date: Thu, 14 Apr 2016 09:50:01 -0700 Organization: UCLA Computer Science Department Message-ID: <570FCA39.1070109@cs.ucla.edu> References: <56CCD91E.6070507@alice.it> <83egc2ixji.fsf@gnu.org> <56CD798D.7060102@alice.it> <56CD8408.1000701@alice.it> <83wppuggb4.fsf@gnu.org> <56CE2CA7.5050906@alice.it> <83io1cg2pt.fsf@gnu.org> <56DA0327.2030009@alice.it> <83oaatxu72.fsf@gnu.org> <570C4307.6050907@alice.it> <83k2k2g82s.fsf@gnu.org> <86egaa7b0z.fsf@gmail.com> <83a8kyfd38.fsf@gnu.org> <86lh4hm7dd.fsf@gmail.com> <570FBFEB.90803@cs.ucla.edu> <83r3e8duxh.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020403050309080405050500" X-Trace: ger.gmane.org 1460652652 32125 80.91.229.3 (14 Apr 2016 16:50:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 Apr 2016 16:50:52 +0000 (UTC) Cc: phillip.lord@russet.org.uk, andrewjmoreton@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 14 18:50:44 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aqkTb-0006SK-KC for ged-emacs-devel@m.gmane.org; Thu, 14 Apr 2016 18:50:43 +0200 Original-Received: from localhost ([::1]:43029 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqkTb-0005M9-3i for ged-emacs-devel@m.gmane.org; Thu, 14 Apr 2016 12:50:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqkT5-0005Hw-0m for emacs-devel@gnu.org; Thu, 14 Apr 2016 12:50:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqkT4-00065N-BV for emacs-devel@gnu.org; Thu, 14 Apr 2016 12:50:10 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:46681) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqkSy-0005zz-4H; Thu, 14 Apr 2016 12:50:04 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3D304160E69; Thu, 14 Apr 2016 09:50:02 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id bW-Mg0GGkAmO; Thu, 14 Apr 2016 09:50:01 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 840DE161272; Thu, 14 Apr 2016 09:50:01 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LXs6_4A0KJHG; Thu, 14 Apr 2016 09:50:01 -0700 (PDT) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6B30916126F; Thu, 14 Apr 2016 09:50:01 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 In-Reply-To: <83r3e8duxh.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:202922 Archived-At: This is a multi-part message in MIME format. --------------020403050309080405050500 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 04/14/2016 09:19 AM, Eli Zaretskii wrote: > No, we set the mode to be binary by default in emacs_open, if text > isn't explicitly requested: Ah, in that case we can simplify emacs_open callers, as they no longer need to worry about O_BINARY and this will help to lessen confusion such as mine. I installed the attached patch on master. --------------020403050309080405050500 Content-Type: application/x-patch; name="0001-Simplify-use-of-O_BINARY.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Simplify-use-of-O_BINARY.patch" RnJvbSA3MWRhNmJlMTM1NTg4MTAyNjYzZjllZmUyN2Y1ZWFkNjUxYjBmMGVlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUaHUsIDE0IEFwciAyMDE2IDA5OjQ3OjE4IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gU2ltcGxpZnkgdXNlIG9mIE9fQklOQVJZCgoqIHNyYy9jYWxscHJvYy5jIChjYWxsX3By b2Nlc3MpOgoqIHNyYy9maWxlaW8uYyAod3JpdGVfcmVnaW9uKToKKiBzcmMvZmlsZWxvY2su YyAocmVhZF9sb2NrX2RhdGEpOgoqIHNyYy9pbWFnZS5jICh4X2ZpbmRfaW1hZ2VfZmQpOgoq IHNyYy9scmVhZC5jIChvcGVucCk6Ciogc3JjL3N5c2RlcC5jIChpbml0X3JhbmRvbSwgZW1h Y3NfZm9wZW4pOgoqIHNyYy91bmV4Y3cuYyAodW5leGVjKToKT21pdCB1bm5lY2Vzc2FyeSB1 c2Ugb2YgT19CSU5BUlksIHNpbmNlIGVtYWNzX29wZW4gbm93IGFycmFuZ2VzCnRoYXQgZm9y IHVzLgotLS0KIHNyYy9jYWxscHJvYy5jIHwgMyArLS0KIHNyYy9maWxlaW8uYyAgIHwgNCAr Ky0tCiBzcmMvZmlsZWxvY2suYyB8IDIgKy0KIHNyYy9pbWFnZS5jICAgIHwgMiArLQogc3Jj L2xyZWFkLmMgICAgfCAzICstLQogc3JjL3N5c2RlcC5jICAgfCAzICstLQogc3JjL3VuZXhj dy5jICAgfCA0ICsrLS0KIDcgZmlsZXMgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCAxMiBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvY2FsbHByb2MuYyBiL3NyYy9jYWxscHJv Yy5jCmluZGV4IDg1Nzg1NTYuLjNhNDA2MjYgMTAwNjQ0Ci0tLSBhL3NyYy9jYWxscHJvYy5j CisrKyBiL3NyYy9jYWxscHJvYy5jCkBAIC01NjUsOCArNTY1LDcgQEAgY2FsbF9wcm9jZXNz IChwdHJkaWZmX3QgbmFyZ3MsIExpc3BfT2JqZWN0ICphcmdzLCBpbnQgZmlsZWZkLAogICAg IHsKICAgICAgIC8qIFNpbmNlIENSTEYgaXMgY29udmVydGVkIHRvIExGIHdpdGhpbiBgZGVj b2RlX2NvZGluZycsIHdlCiAJIGNhbiBhbHdheXMgb3BlbiBhIGZpbGUgd2l0aCBiaW5hcnkg bW9kZS4gICovCi0gICAgICBjYWxscHJvY19mZFtDQUxMUFJPQ19QSVBFUkVBRF0gPSBlbWFj c19vcGVuICh0ZW1wZmlsZSwKLQkJCQkJCSAgIE9fUkRPTkxZIHwgT19CSU5BUlksIDApOwor ICAgICAgY2FsbHByb2NfZmRbQ0FMTFBST0NfUElQRVJFQURdID0gZW1hY3Nfb3BlbiAodGVt cGZpbGUsIE9fUkRPTkxZLCAwKTsKICAgICAgIGlmIChjYWxscHJvY19mZFtDQUxMUFJPQ19Q SVBFUkVBRF0gPCAwKQogCXsKIAkgIGludCBvcGVuX2Vycm5vID0gZXJybm87CmRpZmYgLS1n aXQgYS9zcmMvZmlsZWlvLmMgYi9zcmMvZmlsZWlvLmMKaW5kZXggMGExNGQ2NC4uNzhjYzY2 ZCAxMDA2NDQKLS0tIGEvc3JjL2ZpbGVpby5jCisrKyBiL3NyYy9maWxlaW8uYwpAQCAtNDgw NCw3ICs0ODA0LDcgQEAgd3JpdGVfcmVnaW9uIChMaXNwX09iamVjdCBzdGFydCwgTGlzcF9P YmplY3QgZW5kLCBMaXNwX09iamVjdCBmaWxlbmFtZSwKIAogICBlbmNvZGVkX2ZpbGVuYW1l ID0gRU5DT0RFX0ZJTEUgKGZpbGVuYW1lKTsKICAgZm4gPSBTU0RBVEEgKGVuY29kZWRfZmls ZW5hbWUpOwotICBvcGVuX2ZsYWdzID0gT19XUk9OTFkgfCBPX0JJTkFSWSB8IE9fQ1JFQVQ7 CisgIG9wZW5fZmxhZ3MgPSBPX1dST05MWSB8IE9fQ1JFQVQ7CiAgIG9wZW5fZmxhZ3MgfD0g RVEgKG11c3RiZW5ldywgUWV4Y2wpID8gT19FWENMIDogIU5JTFAgKGFwcGVuZCkgPyAwIDog T19UUlVOQzsKICAgaWYgKE5VTUJFUlAgKGFwcGVuZCkpCiAgICAgb2Zmc2V0ID0gZmlsZV9v ZmZzZXQgKGFwcGVuZCk7CkBAIC00OTIzLDcgKzQ5MjMsNyBAQCB3cml0ZV9yZWdpb24gKExp c3BfT2JqZWN0IHN0YXJ0LCBMaXNwX09iamVjdCBlbmQsIExpc3BfT2JqZWN0IGZpbGVuYW1l LAogICBpZiAodGltZXNwZWNfdmFsaWRfcCAobW9kdGltZSkKICAgICAgICYmICEgKHZhbGlk X3RpbWVzdGFtcF9maWxlX3N5c3RlbSAmJiBzdC5zdF9kZXYgPT0gdGltZXN0YW1wX2ZpbGVf c3lzdGVtKSkKICAgICB7Ci0gICAgICBpbnQgZGVzYzEgPSBlbWFjc19vcGVuIChmbiwgT19X Uk9OTFkgfCBPX0JJTkFSWSwgMCk7CisgICAgICBpbnQgZGVzYzEgPSBlbWFjc19vcGVuIChm biwgT19XUk9OTFksIDApOwogICAgICAgaWYgKGRlc2MxID49IDApCiAJewogCSAgc3RydWN0 IHN0YXQgc3QxOwpkaWZmIC0tZ2l0IGEvc3JjL2ZpbGVsb2NrLmMgYi9zcmMvZmlsZWxvY2su YwppbmRleCBjNTg0ODRhLi42ZGI2ZGFhIDEwMDY0NAotLS0gYS9zcmMvZmlsZWxvY2suYwor KysgYi9zcmMvZmlsZWxvY2suYwpAQCAtNDg1LDcgKzQ4NSw3IEBAIHJlYWRfbG9ja19kYXRh IChjaGFyICpsZm5hbWUsIGNoYXIgbGZpbmZvW01BWF9MRklORk8gKyAxXSkKICAgd2hpbGUg KChuYnl0ZXMgPSByZWFkbGlua2F0IChBVF9GRENXRCwgbGZuYW1lLCBsZmluZm8sIE1BWF9M RklORk8gKyAxKSkgPCAwCiAJICYmIGVycm5vID09IEVJTlZBTCkKICAgICB7Ci0gICAgICBp bnQgZmQgPSBlbWFjc19vcGVuIChsZm5hbWUsIE9fUkRPTkxZIHwgT19CSU5BUlkgfCBPX05P Rk9MTE9XLCAwKTsKKyAgICAgIGludCBmZCA9IGVtYWNzX29wZW4gKGxmbmFtZSwgT19SRE9O TFkgfCBPX05PRk9MTE9XLCAwKTsKICAgICAgIGlmICgwIDw9IGZkKQogCXsKIAkgIC8qIFVz ZSByZWFkLCBub3QgZW1hY3NfcmVhZCwgc2luY2UgRkQgaXNuJ3QgdW53aW5kLXByb3RlY3Rl ZC4gICovCmRpZmYgLS1naXQgYS9zcmMvaW1hZ2UuYyBiL3NyYy9pbWFnZS5jCmluZGV4IDg2 NzQ1MDUuLjJhN2MyY2MgMTAwNjQ0Ci0tLSBhL3NyYy9pbWFnZS5jCisrKyBiL3NyYy9pbWFn ZS5jCkBAIC0yMzAwLDcgKzIzMDAsNyBAQCB4X2ZpbmRfaW1hZ2VfZmQgKExpc3BfT2JqZWN0 IGZpbGUsIGludCAqcGZkKQogCSAgICAgaGFwcGVucywgZS5nLiwgdW5kZXIgQXV0byBJbWFn ZSBGaWxlIE1vZGUuKSAgJ29wZW5wJwogCSAgICAgZGlkbid0IG9wZW4gdGhlIGZpbGUsIHNv IHdlIHNob3VsZCwgYmVjYXVzZSB0aGUgY2FsbGVyCiAJICAgICBleHBlY3RzIHRoYXQuICAq LwotCSAgZmQgPSBlbWFjc19vcGVuIChTU0RBVEEgKGZpbGVfZm91bmQpLCBPX1JET05MWSB8 IE9fQklOQVJZLCAwKTsKKwkgIGZkID0gZW1hY3Nfb3BlbiAoU1NEQVRBIChmaWxlX2ZvdW5k KSwgT19SRE9OTFksIDApOwogCX0KICAgICB9CiAgIGVsc2UJLyogZmQgPCAwLCBidXQgbm90 IC0yICovCmRpZmYgLS1naXQgYS9zcmMvbHJlYWQuYyBiL3NyYy9scmVhZC5jCmluZGV4IDkx NDY5MjMuLmZlZGZjYjggMTAwNjQ0Ci0tLSBhL3NyYy9scmVhZC5jCisrKyBiL3NyYy9scmVh ZC5jCkBAIC0xNTc4LDggKzE1NzgsNyBAQCBvcGVucCAoTGlzcF9PYmplY3QgcGF0aCwgTGlz cF9PYmplY3Qgc3RyLCBMaXNwX09iamVjdCBzdWZmaXhlcywKIAkJfQogCSAgICAgIGVsc2UK IAkJewotCQkgIGludCBvZmxhZ3MgPSBPX1JET05MWSArIChOSUxQIChwcmVkaWNhdGUpID8g MCA6IE9fQklOQVJZKTsKLQkJICBmZCA9IGVtYWNzX29wZW4gKHBmbiwgb2ZsYWdzLCAwKTsK KwkJICBmZCA9IGVtYWNzX29wZW4gKHBmbiwgT19SRE9OTFksIDApOwogCQkgIGlmIChmZCA8 IDApCiAJCSAgICB7CiAJCSAgICAgIGlmIChlcnJubyAhPSBFTk9FTlQpCmRpZmYgLS1naXQg YS9zcmMvc3lzZGVwLmMgYi9zcmMvc3lzZGVwLmMKaW5kZXggMWUzYjlmMS4uM2ZhYTY5NiAx MDA2NDQKLS0tIGEvc3JjL3N5c2RlcC5jCisrKyBiL3NyYy9zeXNkZXAuYwpAQCAtMjE0OCw3 ICsyMTQ4LDcgQEAgaW5pdF9yYW5kb20gKHZvaWQpCiAgICAgewogICAgICAgYm9vbCBzdWNj ZXNzID0gZmFsc2U7CiAjaWZuZGVmIFdJTkRPV1NOVAotICAgICAgaW50IGZkID0gZW1hY3Nf b3BlbiAoIi9kZXYvdXJhbmRvbSIsIE9fUkRPTkxZIHwgT19CSU5BUlksIDApOworICAgICAg aW50IGZkID0gZW1hY3Nfb3BlbiAoIi9kZXYvdXJhbmRvbSIsIE9fUkRPTkxZLCAwKTsKICAg ICAgIGlmICgwIDw9IGZkKQogCXsKIAkgIHN1Y2Nlc3MgPSBlbWFjc19yZWFkIChmZCwgJnYs IHNpemVvZiB2KSA9PSBzaXplb2YgdjsKQEAgLTIzMjgsNyArMjMyOCw2IEBAIGVtYWNzX2Zv cGVuIChjaGFyIGNvbnN0ICpmaWxlLCBjaGFyIGNvbnN0ICptb2RlKQogICAgIHN3aXRjaCAo Km0rKykKICAgICAgIHsKICAgICAgIGNhc2UgJysnOiBvbW9kZSA9IE9fUkRXUjsgYnJlYWs7 Ci0gICAgICBjYXNlICdiJzogYmZsYWcgPSBPX0JJTkFSWTsgYnJlYWs7CiAgICAgICBjYXNl ICd0JzogYmZsYWcgPSBPX1RFWFQ7IGJyZWFrOwogICAgICAgZGVmYXVsdDogLyogSWdub3Jl LiAgKi8gYnJlYWs7CiAgICAgICB9CmRpZmYgLS1naXQgYS9zcmMvdW5leGN3LmMgYi9zcmMv dW5leGN3LmMKaW5kZXggMzk5ZTJjMy4uZWE2NzhkZCAxMDA2NDQKLS0tIGEvc3JjL3VuZXhj dy5jCisrKyBiL3NyYy91bmV4Y3cuYwpAQCAtMjc1LDkgKzI3NSw5IEBAIHVuZXhlYyAoY29u c3QgY2hhciAqb3V0ZmlsZSwgY29uc3QgY2hhciAqaW5maWxlKQogICBpbmZpbGUgPSBhZGRf ZXhlX3N1ZmZpeF9pZl9uZWNlc3NhcnkgKGluZmlsZSwgaW5maWxlX2J1ZmZlcik7CiAgIG91 dGZpbGUgPSBhZGRfZXhlX3N1ZmZpeF9pZl9uZWNlc3NhcnkgKG91dGZpbGUsIG91dGZpbGVf YnVmZmVyKTsKIAotICBmZF9pbiA9IGVtYWNzX29wZW4gKGluZmlsZSwgT19SRE9OTFkgfCBP X0JJTkFSWSwgMCk7CisgIGZkX2luID0gZW1hY3Nfb3BlbiAoaW5maWxlLCBPX1JET05MWSwg MCk7CiAgIGFzc2VydCAoZmRfaW4gPj0gMCk7Ci0gIGZkX291dCA9IGVtYWNzX29wZW4gKG91 dGZpbGUsIE9fUkRXUiB8IE9fVFJVTkMgfCBPX0NSRUFUIHwgT19CSU5BUlksIDA3NTUpOwor ICBmZF9vdXQgPSBlbWFjc19vcGVuIChvdXRmaWxlLCBPX1JEV1IgfCBPX1RSVU5DIHwgT19D UkVBVCwgMDc1NSk7CiAgIGFzc2VydCAoZmRfb3V0ID49IDApOwogICBmb3IgKDs7KQogICAg IHsKLS0gCjIuNS41Cgo= --------------020403050309080405050500--